At Wed, 12 Feb 2014 20:37:36 +0000,
Matthew Garrett wrote:
>
> On Wed, 2014-02-12 at 16:32 +0100, Takashi Iwai wrote:
> > The mute LED states have to be restored after resume.
>
> Oh, never mind, we're not doing this through the LED class, are we?
Good point. It seems that leds_class has pm_ops but it's enabled only
when a flag is set.
I added the original bug reporter to Cc. (Don't know the name,
Bugzilla shows only the email address.)
Could you check the patch below works instead of the previous fix?
Takashi
---
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index defb6afc1409..16edf75d9c00 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -4796,6 +4796,7 @@ static struct tpacpi_led_classdev tpacpi_led_thinklight =
{
.name = "tpacpi::thinklight",
.brightness_set = &light_sysfs_set,
.brightness_get = &light_sysfs_get,
+ .flags = LED_CORE_SUSPENDRESUME,
}
};
------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works.
Faster operations. Version large binaries. Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
