On Fri, 2015-02-20 at 11:27 -0800, Andy Lutomirski wrote: > On 02/20/2015 06:44 AM, Bastien Nocera wrote: > > + KEY_MICCANCEL_MODE, /* Microphone cancellation */ > > What's this? We already have KEY_MICMUTE. Is this different? If so, > can you improve the comment a bit?
I don't think the comment needs improving. This is the device driver part of the patch series. If comment was required, it would in the commit adding the keycode to input.h. We're discussing that with Dmitry. > The answer may be obvious to anyone who has an awful X1 carbon gen 2 > keyboard, but these KEY_XYZ defines should IMO be clear enough that even > people without the hardware can figure out what's going on. I'll make sure to link this in the input.h patch: http://www.lenovo.com/shop/americas/content/user_guides/x1carbon_2_ug_en.pdf In any case, it doesn't look like this particular keycode will make it. ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=190641631&iu=/4140/ostg.clktrk _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
