On Fri, 12 Jun 2015, Ramiro Morales wrote:
> Implement change in logging during screen brightness capabilities
> detection as suggested in
> https://www.mail-archive.com/ibm-acpi-devel%40lists.sourceforge.net/msg03484.html
>
> Signed-off-by: Ramiro Morales <cra...@gmail.com>
Acked-by: Henrique de Moraes Holschuh <h...@hmh.eng.br>
Please resend this patch, *adding* these recipients:
Darren Hart <dvh...@infradead.org>, platform-driver-...@vger.kernel.org
(i.e. send it also to me and ibm-acpi-devel, as well as the
platform-driver-x86 ML and its maintainer).
Thank you.
> ---
> drivers/platform/x86/thinkpad_acpi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index 28f3281..b48efc9 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -6450,19 +6450,16 @@ static void __init
> tpacpi_detect_brightness_capabilities(void)
> switch (b) {
> case 16:
> bright_maxlvl = 15;
> - pr_info("detected a 16-level brightness capable ThinkPad\n");
> break;
> case 8:
> case 0:
> bright_maxlvl = 7;
> - pr_info("detected a 8-level brightness capable ThinkPad\n");
> break;
> default:
> - pr_err("Unsupported brightness interface, "
> - "please contact %s\n", TPACPI_MAIL);
> tp_features.bright_unkfw = 1;
> bright_maxlvl = b - 1;
> }
> + pr_debug("firmware reports %d brightness levels\n", bright_maxlvl);
> }
>
> static int __init brightness_init(struct ibm_init_struct *iibm)
> @@ -6482,6 +6479,9 @@ static int __init brightness_init(struct
> ibm_init_struct *iibm)
>
> /* if it is unknown, we don't handle it: it wouldn't be safe */
> if (tp_features.bright_unkfw)
> + dbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_BRGHT,
> + "Unsupported brightness mode, use acpi video "
> + "or gpu drivers");
> return 1;
>
> if (!brightness_enable) {
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
------------------------------------------------------------------------------
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
