From: Mark Pearson <mpearson-len...@squebb.ca>

Modify how known_ev event is handled in preparation for adding new hkey
event range.

Signed-off-by: Mark Pearson <mpearson-len...@squebb.ca>
Link: https://lore.kernel.org/r/20240417173124.9953-1-mpearson-len...@squebb.ca
Reviewed-by: Hans de Goede <hdego...@redhat.com>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
 drivers/platform/x86/thinkpad_acpi.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c 
b/drivers/platform/x86/thinkpad_acpi.c
index fc60857b39ec..cd54a2455ac8 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -3840,6 +3840,7 @@ static void hotkey_notify(struct ibm_struct *ibm, u32 
event)
                }
 
                send_acpi_ev = true;
+               known_ev = false;
 
                switch (hkey >> 12) {
                case 1:
@@ -3863,8 +3864,6 @@ static void hotkey_notify(struct ibm_struct *ibm, u32 
event)
                                /* FIXME: kick libata if SATA link offline */
                                known_ev = true;
                                break;
-                       default:
-                               known_ev = false;
                        }
                        break;
                case 4:
@@ -3887,11 +3886,8 @@ static void hotkey_notify(struct ibm_struct *ibm, u32 
event)
                                tpacpi_send_radiosw_update();
                                send_acpi_ev = 0;
                                known_ev = true;
-                               break;
                        }
-                       fallthrough;    /* to default */
-               default:
-                       known_ev = false;
+                       break;
                }
                if (!known_ev) {
                        pr_notice("unhandled HKEY event 0x%04x\n", hkey);
-- 
2.44.0



_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Reply via email to