We don't seem to have the same definition of clever. To me, code that has me asking "Why didn't I think of that?" is clever; code that has me asking for hours "How does this work?", not so much. Sometimes the difference is good choice of label and helpful comments.
Expect the code to be modified by someone with significantly less knowledge of the problem domain, even if they are an expert in the language. Bad standards are stifling and inefficient; that doesn't mean that all standards are bad. Good standards save time in the long run. -- Shmuel (Seymour J.) Metz http://mason.gmu.edu/~smetz3 עַם יִשְׂרָאֵל חַי נֵ֣צַח יִשְׂרָאֵ֔ל לֹ֥א יְשַׁקֵּ֖ר ________________________________________ From: IBM Mainframe Discussion List <IBM-MAIN@LISTSERV.UA.EDU> on behalf of Jared Hunter <jhun...@rocketsoftware.com> Sent: Sunday, March 17, 2024 4:20 PM To: IBM-MAIN@LISTSERV.UA.EDU Subject: Re: Learning one's tools Dave Beagle wrote: > Code reviews are dumb and not needed by good programmers Counterpoint: Code reviews are -most- essential when the authors are experts. Why is that? Because experts are most able to churn out code that functions correctly for today’s requirements, but that some less-expert future maintainer will have a difficult time modifying to suit a new requirement without introducing a bug. “Standards” may feel stifling and inefficient to someone who wants to output “working” code as quickly as possible, and especially one with a deep desire to display their cleverness. [Dear reader, does that sound like anyone you know?] In general, code written for the set of list-relevant platforms should be reviewed with the expectation that it will be maintained for decades longer than the original author is employed, and eventually by a generalist with significantly less overall depth of compiler-specific or arcane platform knowledge. It’s an extremely hard balance to strike, to be sure, but it’s never too early or too late to start trying. Jared Hunter Rocket Software ================================ Rocket Software, Inc. and subsidiaries ¦ 77 Fourth Avenue, Waltham MA 02451 ¦ Main Office Toll Free Number: +1 855.577.4323 Contact Customer Support: https://my.rocketsoftware.com/RocketCommunity/RCEmailSupport Unsubscribe from Marketing Messages/Manage Your Subscription Preferences - http://www.rocketsoftware.com/manage-your-email-preferences Privacy Policy - http://www.rocketsoftware.com/company/legal/privacy-policy ================================ This communication and any attachments may contain confidential information of Rocket Software, Inc. All unauthorized use, disclosure or distribution is prohibited. If you are not the intended recipient, please notify Rocket Software immediately and destroy all copies of this communication. Thank you. ---------------------------------------------------------------------- For IBM-MAIN subscribe / signoff / archive access instructions, send email to lists...@listserv.ua.edu with the message: INFO IBM-MAIN ---------------------------------------------------------------------- For IBM-MAIN subscribe / signoff / archive access instructions, send email to lists...@listserv.ua.edu with the message: INFO IBM-MAIN
