On 28.04.2012 11:39, Thomas Dressler wrote:
> Am 28.04.2012 11:25, schrieb Michael Friedrich:
>> as outlined in the issue, you can't simply "remove" the old version. how
>> would you know about the location, and if you are allowed to call 'rm'?
>> Solely this only works on source installs, and not packages.
> Hm, i assumed, especially in a package the path is known, because it was
> defined in the previous package. AFAIK there are upgrade/postinstall
> scripts in the package definition, which could take care about it. And
> if sombody choosed to locate it somewhere, ok this we cannot catch. But
> i think for the majority of users it may work.
i still don't like rm.
rather not load the module.
Apr 28 12:31:02 icinga-dev icinga: Error: trying to load module
'/usr/bin/idomod.o' which has been moved to libdir/idomod.so in Icinga 1.7!
Apr 28 12:31:02 icinga-dev icinga: Check Changelog and upgrade docs to
update the broker module entry!
try that diff against current r1.7
diff --git a/base/nebmods.c b/base/nebmods.c
index c69f97d..071ec1c 100644
--- a/base/nebmods.c
+++ b/base/nebmods.c
@@ -184,8 +184,11 @@ int neb_load_module(nebmodule *mod) {
return ERROR;
/* add a compatibility check for 1.7 change of idomod.o ->
idomod.so */
- if (strstr(mod->filename, "idomod.o") != NULL)
- logit(NSLOG_RUNTIME_ERROR, FALSE, "Error: trying to load
module '%s' which has been deprecated! Check Changelog and upgrade
docs!\n", mod->filename);
+ if (strstr(mod->filename, "idomod.o") != NULL) {
+ logit(NSLOG_RUNTIME_ERROR, FALSE, "Error: trying to load
module '%s' which has been moved to libdir/idomod.so in Icinga 1.7!\n",
mod->filename);
+ logit(NSLOG_RUNTIME_ERROR, FALSE, "Check Changelog and
upgrade docs to update the broker module entry!\n");
+ return ERROR;
+ }
/**********
Using dlopen() is great, but a real danger as-is. The
problem with loaded modules is that if you overwrite the original file
(e.g. using 'mv'),
>
>
> Thomas
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> icinga-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/icinga-devel
--
DI (FH) Michael Friedrich
Vienna University Computer Center
Universitaetsstrasse 7 A-1010 Vienna, Austria
email: [email protected]
phone: +43 1 4277 14359
mobile: +43 664 60277 14359
fax: +43 1 4277 14338
web: http://www.univie.ac.at/zid
http://www.aco.net
Lead Icinga Core Developer
http://www.icinga.org
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
icinga-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/icinga-devel
