On 22.01.2012 22:32, Carl R. Friend wrote:
> On Tue, 17 Jan 2012, Michael Friedrich wrote:
>
>> Just keep in mind that this won't solve the libdbi problem you are
>> having on your arch.
>
> Indeed it didn't, but I got some time today to fiddle with it and
> it looks like I've got it solved.
>
> This was a multi-pronged problem, some of which was in my build
> environment (two concurrent versions of MySQL running and limking
> against the "wrong" one) and some code problems in the ido2db.c
> file.
>
> The former I got rid of by removing the old MySQL-4 installation
> and the latter by cleaning up some stuff.
is it now mysql5? i don't recall exactly where 5.x was the minimum
requirement, but there was some (maybe libdbi as is).
>
>
> Specifically, in ido2db.c, at line 1457, changing
>
> printf(" USED1: %lu, BYTES: %lu, LINES: %lu\n", dbuf->used_size,
> idi->bytes_processed, idi->lines_processed);
>
> to
>
> printf(" USED1: %lu, BYTES: %lu, LINES: %lu\n", dbuf.used_size,
> idi->bytes_processed, idi->lines_processed);
>
> which was causing compilation errors when DEBUG_IDO2DB2 was defined,
> This was a by-product of the ndoutils code passing "dbuf" in via
> the function call where idoutils has "dbuf" as a global.
tbh i haven't checked that define lately. thanks for analyzing though.
>
>
> commenting out a debug statement at line 1510 (not the best avenue,
> I know, and I'll come up with something beter),
it does not hurt to do so. many of those debug statements happened
because on the origin ndoutils code you failed to get the design and
possible cause of errors.
>
>
> and adding some sanity-checking at lines 1820 and 1821 to avoid
> passing a null pointer:
>
> (val == NULL) ? "" : val
>
> instead of passing val out unchecked.
>
> Once I have a proper fix for the debug statement (which can
> be called when the instance_name is still unset) I'll do up a
> proper patch. Should I submit this, and if so, to where?
preferred method is a git patch against current master.
https://wiki.icinga.org/display/Dev/Developer+Guidelines#DeveloperGuidelines-Patches
an icinga version on riding the git can be found in the wiki as well
https://wiki.icinga.org/display/Dev/Riding+the+Git
you can either send it here, but i for myself prefer an issue on the dev
tracker where you'll attach the patch/diff then.
such an issue should also contain a summary of what you wrote here as
well as your final thoughts on the issue.
https://dev.icinga.org - core - idoutils section for this problem. we'll
then organize who gets the ticket and manage the target version (1.6.2
or 1.7.x) in this case.
thanks in advance though, your analysis sounds pretty straight forward
and correct.
if you happen to have problems with git, just send a patch file instead.
it shouldn't be the matter of tools used.
>
>
> By the by, all the work was done on gcc 2.95.3, so that means
> that I wasn't staring at a compiler error.
as mentioned before, i got some issues before with it, so i am not
entirely convinced by such errors if the compiler isn't a possible cause.
but i am happy to see you fiddling with it and i'd be happy to have you
with a sparc platform around - also to test future releases on git.
>
>
> Now it's just a matter of lightly massaging some of my plugins
> and I can retire Nagios.
if you got any special hints for other sparc users out there, feel free
to write something onto the icinga community wiki as well - the howto
space is waiting :)
kind regards,
michael
>
>
> Cheers!
>
> +------------------------------------------------+---------------------+
> | Carl Richard Friend (UNIX Sysadmin) | West Boylston |
> | Minicomputer Collector / Enthusiast | Massachusetts, USA |
> | mailto:[email protected] +---------------------+
> | http://users.rcn.com/crfriend/museum | ICBM: 42:22N 71:47W |
> +------------------------------------------------+---------------------+
>
> ------------------------------------------------------------------------------
> Try before you buy = See our experts in action!
> The most comprehensive online learning library for Microsoft developers
> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
> Metro Style Apps, more. Free future releases when you subscribe now!
> http://p.sf.net/sfu/learndevnow-dev2
> _______________________________________________
> icinga-users mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/icinga-users
--
DI (FH) Michael Friedrich
Vienna University Computer Center
Universitaetsstrasse 7 A-1010 Vienna, Austria
email: [email protected]
phone: +43 1 4277 14359
mobile: +43 664 60277 14359
fax: +43 1 4277 14338
web: http://www.univie.ac.at/zid
http://www.aco.net
Lead Icinga Core Developer
http://www.icinga.org
------------------------------------------------------------------------------
Try before you buy = See our experts in action!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-dev2
_______________________________________________
icinga-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/icinga-users
