Author: prabath
Date: Thu Feb 21 21:31:17 2008
New Revision: 14019

Log:

code formatting + comments

Modified:
   
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/openid/UserInfoServlet.java
   
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/users/IdentityDefaultUserStoreAdmin.java
   
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/users/IdentityDefaultUserStoreReader.java
   
trunk/solutions/identity/modules/user-ui/src/main/java/org/wso2/solutions/identity/user/ui/action/OpenIDAuthVerificationAction.java

Modified: 
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/openid/UserInfoServlet.java
==============================================================================
--- 
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/openid/UserInfoServlet.java
    (original)
+++ 
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/openid/UserInfoServlet.java
    Thu Feb 21 21:31:17 2008
@@ -63,9 +63,7 @@
 
     /**
      * Check whether the given user exists in the system.
-     * 
-     * @param userName
-     *                User name.
+     * @param userName User name.
      * @return
      */
     private boolean isUserExist(String userName) {

Modified: 
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/users/IdentityDefaultUserStoreAdmin.java
==============================================================================
--- 
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/users/IdentityDefaultUserStoreAdmin.java
       (original)
+++ 
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/users/IdentityDefaultUserStoreAdmin.java
       Thu Feb 21 21:31:17 2008
@@ -26,9 +26,7 @@
 
     /**
      * Class constructor specifying the data-source
-     * 
-     * @param dataSource
-     *                DataSource
+     * @param dataSource DataSource
      */
     public IdentityDefaultUserStoreAdmin(DataSource dataSource) {
         super(dataSource);
@@ -37,11 +35,8 @@
 
     /**
      * Class constructor specifying the data-source and the default strategy
-     * 
-     * @param dataSource
-     *                DataSource
-     * @param store
-     *                DefaultStrategy
+     * @param dataSource DataSource
+     * @param store DefaultStrategy
      */
     public IdentityDefaultUserStoreAdmin(DataSource dataSource,
             DefaultStrategy store) {
@@ -153,15 +148,10 @@
 
     /**
      * Add a new profile for a given user.
-     * 
-     * @param userId
-     *                User Id
-     * @param profileId
-     *                Profile Id
-     * @param isDefault
-     *                Indicates whether the given profile is default or not
-     * @param profileName
-     *                Name of the profile
+     * @param userId User Id
+     * @param profileId Profile Id
+     * @param isDefault Indicates whether the given profile is default or not
+     * @param profileName Name of the profile
      * @throws UserManagerException
      */
     protected void addUserProfile(String userId, String profileId,

Modified: 
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/users/IdentityDefaultUserStoreReader.java
==============================================================================
--- 
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/users/IdentityDefaultUserStoreReader.java
      (original)
+++ 
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/users/IdentityDefaultUserStoreReader.java
      Thu Feb 21 21:31:17 2008
@@ -26,9 +26,7 @@
 
     /**
      * Class constructor specifying the data-source
-     * 
-     * @param dataSource
-     *                DataSource
+     * @param dataSource DataSource
      */
     public IdentityDefaultUserStoreReader(DataSource dataSource) {
         super(dataSource);
@@ -37,11 +35,8 @@
 
     /**
      * Class constructor specifying the data-source and the default strategy
-     * 
-     * @param dataSource
-     *                DataSource
-     * @param store
-     *                DefaultStrategy
+     * @param dataSource DataSource
+     * @param store DefaultStrategy
      */
     public IdentityDefaultUserStoreReader(DataSource dataSource,
             DefaultStrategy store) {

Modified: 
trunk/solutions/identity/modules/user-ui/src/main/java/org/wso2/solutions/identity/user/ui/action/OpenIDAuthVerificationAction.java
==============================================================================
--- 
trunk/solutions/identity/modules/user-ui/src/main/java/org/wso2/solutions/identity/user/ui/action/OpenIDAuthVerificationAction.java
 (original)
+++ 
trunk/solutions/identity/modules/user-ui/src/main/java/org/wso2/solutions/identity/user/ui/action/OpenIDAuthVerificationAction.java
 Thu Feb 21 21:31:17 2008
@@ -137,10 +137,12 @@
                     .getParameter(IdentityProviderConstants.OpenId.PASSWORD);
 
             if (password == null) {
-                password = (String) session.getAttribute("password");
+                password = (String) session
+                        
.getAttribute(IdentityProviderConstants.OpenId.PASSWORD);
 
                 if (password != null)
-                    session.removeAttribute("password");
+                    session
+                            
.removeAttribute(IdentityProviderConstants.OpenId.PASSWORD);
             }
 
             if (UserUtil.doLogin(user, password)) {
@@ -191,8 +193,8 @@
     }
 
     /**
-     * 
-     * @param userName
+     * Populates user profiles with all his profile names.
+     * @param userName Unique user name
      * @throws RelyingPartyException
      */
     protected void populateUserProfiles(String userName, String rpUrl)
@@ -236,9 +238,8 @@
     /**
      * Check whether user has already agreed to accept request from this RP
      * always
-     * 
-     * @param request
-     * @return
+     * @param request HttpServletRequest
+     * @return true if required user approval, else false
      * @throws RelyingPartyException
      */
     private boolean isRequiredUserApproval(HttpServletRequest request)

_______________________________________________
Identity-dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/identity-dev

Reply via email to