Hi, On Sun, 2006-12-03 at 16:32 +0000, Anand Kumria wrote: > If this is being stored in a VCS, then why keep the old test > around in the file? >
My bad!! This is my first attempt with fiddling with autotools, and so had not removed the previous commands. Forgot to delete those commented lines before generating the patch. :( > Also, is that check going to work like you think it does? > > I get: > > eve:[~]% pkg-config --modversion xsp > 0.1 > > This is with Debian 4.0 (what will be 4.0 at any rate), even though I have > > eve:[~]% dpkg -l | grep xsp > ii mono-xsp 1.1.18-1 > simple web server to run ASP.NET applications > ii mono-xsp-base 1.1.18-1 > base libraries for XSP 1.1 > ii mono-xsp2 1.1.18-1 > simple web server to run ASP.NET applications > ii mono-xsp2-base 1.1.18-1 > base libraries for XSP 2.0 > > installed. I think, you would be better off doing: > > eve:[~]% xsp --version > xsp.exe 1.1.18.0 > (c) (c) 2002-2006 Novell, Inc. > Minimalistic web server for testing System.Web > > and grabbing the version from there. > hmm... I was too quick to trust the xsp.pc file that comes with mono-xsp-base (in Debian, and xsp package in SuSE). I *assumed* that the version info will be put in correctly in the .pc file. :( I guess, picking the version of xsp has to be done after parsing the output of `xsp --version`. > Finally, why are you even checking the OS type? If mono exists > on the platform (for example, Mac OS X, Solaris, Windows), why _wouldn't_ > you want to use the in-built webserver? > If we don't ceck the platfom, then `pkg-config --modversion xsp` will be run for both Win32 and MAC, which would fail for non-existence of xsp.pc file. In the current Makefiles, if $MONO_WEBSERVER is set to "yes", they pick the DLL file from the GAC. If $MONO_WEBSERVER is set to "no", they pick the DLL from the external/ directory inside the source tree. Since there's no xsp.pc file in Windows or MAC, we can simply use the external/ directory to link against Mono.WebServer.dll from there and need not fail for not finding the xsp package. I'll re-send the patch with appropriate changes. Thanks, Srinidhi. -- ASCII ribbon campaign ( ) B S Srinidhi - against HTML email X http://www.srinidhi-is.in & vCards / \ Bangalore _______________________________________________ ifolder-dev mailing list [email protected] http://forge.novell.com/mailman/listinfo/ifolder-dev
