Hi Gabor Glad to hear it is not just me being careless. It would be great if you or someone else could make the request as I am not familiar with GitHub.
Perhaps the solution is to simply create one new ‘master’ function, call it ‘community_detection’ or something, and have a numbered list of input arguments 1-8 for these 8 methods, then you could have a single input NA or NULL for the weight argument. Having just one function would be very convenient, and I do not think the algorithms are so complex that they need to be in separate functions. Edmund > On 25 May 2017, at 11:10, Gábor Csárdi <[email protected]> wrote: > > YEah, that is a mess. > > It is not so easy to change to just NA (or just NULL), because it will > not be compatible. > > So maybe we should introduce a completely new mechanism, and switch to > that. That at least does not give you the illusion is that it works > when it does not. > > Do you want to open a GitHub issue for this? > > Gabor > > On Thu, May 25, 2017 at 11:05 AM, Edmund Hunt <[email protected]> wrote: >> Ah I see, thank you Szabolcs! >> >> I am using several clustering methods available in igraph at once to compare >> outputs, so this is completely inconsistent between methods!!! >> >> cluster_edge_betweenness - uses NULL to omit edge weights >> cluster_fast_greedy - uses NULL to omit edge weights (though it is not clear >> on this point?) >> cluster_label_prop - uses NA, but in the ‘usage’ states NULL >> cluster_leading_eigen - uses NA, but in the ‘usage’ states NULL >> cluster_louvain - uses NA, but in the ‘usage’ states NULL >> cluster_optimal - uses NA, but in the ‘usage’ states NULL >> cluster_walktrap - does not provide any guidance, I assumed NULL was used >> cluster_spinglass - uses NA, but usage states NULL >> >> I am still quite new to R so perhaps the ‘usage’ is meant to be read >> differently, but I thought it meant NULL could be used as a meaningful input >> >> Please could this be fixed so there is a uniform and clear approach in the >> next update to igraph, as it is very confusing at present >> >> Thanks, >> >> Edmund >> > > _______________________________________________ > igraph-help mailing list > [email protected] > https://lists.nongnu.org/mailman/listinfo/igraph-help _______________________________________________ igraph-help mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/igraph-help
