In principle, I agree. However it might break some code in a bad way. We used
several times constructs like
Img< T > img;
if ( img instanceOf ImagePlusImg )
{
// get the underlying instance (which is especially true after wrapping)
ImagePlus imp = ((ImagePlusImg)img).getImagePlus();
....
// or do something else where you test instanceof
}
which would suddenly fail because ImgPlus is an Img, but only HAS for example
an ImagePlusImg...
What do you think?
Bye bye,
Steffi
On Jul 12, 2012, at 16:33 , Curtis Rueden wrote:
> Hi Steffi,
>
>
> you could just add another wrap method that does that if you like ... seems
> useful to me . ...
>
> I agree with J-Y: the wrap methods could always return ImgPlus, since an
> ImgPlus is also an Img. No reduction in functionality there.
>
> -Curtis
>
>
> On Thu, Jul 12, 2012 at 3:30 PM, Stephan Preibisch <[email protected]>
> wrote:
> Hi J-Y,
>
> you could just add another wrap method that does that if you like ... seems
> useful to me . ...
>
> Bye bye,
> Steffi
>
> On Jul 12, 2012, at 16:28 , Jean-Yves Tinevez wrote:
>
>>
>>>>
>>>>
>>>> I would like to add the following methods to CalibratedSapce.java
>>>>
>>>> I think these methods are good additions!
>>>>
>>>>
>>>> /** Sets the image calibration for the given dimension. */
>>>> void setCalibration(double[] cal);
>>>> /** Sets the image calibration for the given dimension. */
>>>> void setCalibration(float[] cal);
>>>>
>>>> Shouldn't the javadoc for these read "Sets the image calibration from the
>>>> given array." or similar?
>>
>> Hi all
>>
>> Any chance ImagePlusAdapter wrap() methods return an ImgPlus?
>>
>> Cheers
>> jy
>
>
> --
> Please avoid top-posting, and please make sure to reply-to-all!
>
> Mailing list web interface: http://groups.google.com/group/fiji-devel
>
>
> --
> Please avoid top-posting, and please make sure to reply-to-all!
>
> Mailing list web interface: http://groups.google.com/group/fiji-devel
_______________________________________________
ImageJ-devel mailing list
[email protected]
http://imagej.net/mailman/listinfo/imagej-devel
