Hi Brian,

you are absolutely right, this is a bug. I fixed the bug and added your test-case to our CroppedIterableIntervalTest class (I hope that's OK?!).

Thank you for reporting the bug!

Christian

PS: I don't really like the name "CroppedIterableInterval", as we don't really crop something. Any suggestions?


On 12.06.2014 21:45, Brian Northan wrote:
Hi List

I was trying to figure out how the CroppedIterableInterval in imagej-ops works.

My understanding is that the "axesOfInterest" array defines the axes of the resulting "cropped hypeslices". So if you have x as axis 0, y:1, c:2, z:3 and t:4 and you specify 0 (x), 1 (y), and 3 (z) as the "axesOfInterest" it should loop through c and t and return x,y,z hyperslices? Is that correct??

If I am correct in my assumption of how it works I noticed one thing that is possibly a bug (if I misunderstood how it is supposed to work disregard the rest of this e-mail).

Around line 100

/if (axesOfInterest[j] == i) { dimensionsToIterate[** j ** ] = 1;/

should maybe be

/dimensionsToIterate[ ** i **]=1;/

I have a test that only works if I change the above line of code in a local copy of CroppedIterableInterval.java

The test is here: https://github.com/DeconWaRE/deconware-ops/blob/master/src/test/java/com/deconware/ops/SlicerTest.java

Brian



_______________________________________________
ImageJ-devel mailing list
[email protected]
http://imagej.net/mailman/listinfo/imagej-devel

_______________________________________________
ImageJ-devel mailing list
[email protected]
http://imagej.net/mailman/listinfo/imagej-devel

Reply via email to