Hi, I'm not suggesting that the classloader is completely ignored; it is indeed evaluated at the first invocation but then if the following method is invoked again with a different classloader as argument, it will return the previously cached value:
https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/util/ModuleProperties.java#L135 Note that the method you pointed to is private, and is actually a helper for the public methods, which does cache all of it's results in static fields. So assuming this will be invoked by a single classloader only, indeed there are no issues. But is that really the case? Wasn't the purpose of the classloader parameter to load extensions from a deployed application? If so, it seems I can't deploy two different applications both attempting to start an Infinispan cachemanager. For example, I suspect that you won't be able to deploy an Hibernate Search application (or Infinispan Query) and then deploy a Hibernate OGM based application in the same container. But this is not proven as I didn't try it out, so maybe my assumptions about what the goal of this classloader parameter are wrong. So I think that, iff we need to cache this information, it shouldn't be cached in a static field, as discussed as well on https://issues.jboss.org/browse/ISPN-1190 Cheers, Sanne On 12 September 2011 19:10, Manik Surtani <[email protected]> wrote: > Sanne, > WRT https://issues.jboss.org/browse/ISPN-1374 > I don't see the class loader being ignored? It is used to load the > module.properties file (by passing it into FileLookup [1]). FileLookup has > a regular impl as well as an OSGi impl which is capable of scanning > different bundles. Have you seen any specific bugs around this? > Cheers > Manik > [1] https://github.com/infinispan/infinispan/blob/master/core/src/main/java/org/infinispan/util/ModuleProperties.java#L112 > -- > Manik Surtani > [email protected] > twitter.com/maniksurtani > Lead, Infinispan > http://www.infinispan.org > > > > _______________________________________________ > infinispan-dev mailing list > [email protected] > https://lists.jboss.org/mailman/listinfo/infinispan-dev > _______________________________________________ infinispan-dev mailing list [email protected] https://lists.jboss.org/mailman/listinfo/infinispan-dev
