Thanks Mircea. I've made some comments. To all:
If you're gonna submit a big pull req, please use the description to *summarise the changes* in order to help reviewers. This helps focus the attention of the reviewer to the pieces of code that are most relevant. On Sep 27, 2011, at 7:10 PM, Mircea Markus wrote: > Hi, > > I've issued a pull request for SPN-1131 (Add support for optimistic locking). > My last run brought the same number of test failures in master and in my > branch, so might be a good idea to integrate it first and then continue > fixing tests. > > Cheers, > Mircea > > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev -- Galder Zamarreño Sr. Software Engineer Infinispan, JBoss Cache _______________________________________________ infinispan-dev mailing list infinispan-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev