Well, I see one problem with my patch already:

--- Stephen Cameron <[EMAIL PROTECTED]> wrote:

This part, from cvs.texinfo:
+ 
+ CAUTION: the special tag `HEAD' is interpreted by
+ the `cvs diff' command in a different way than it
+ is interpreted by any other cvs command.  `cvs diff'
+ takes `-r HEAD' to mean the following, as nearly as
+ I can tell:
+ 
+ For `cvs diff', `HEAD' means the most recent revision
+ on the `current branch' (taking into account whatever
+ sticky tags are active in your working directory) unless
+ the particular file being diffed is not present on the
+ branch, in which case the head revision of the trunk is
+ taken.  It is evident that there are at least some cases
+ for which this definition fails, that is, the wrong 
+ revision may be found by `cvs diff' when used in combination
+ with `-r HEAD'.  You may wish to use `.trunk' rather than
+ `HEAD'.  The `.trunk' tag acts as a branch tag name for the
+ trunk.
+ 

is not correct nor consistent with this part:
  /*
!  * Special tags. 
!  * -rHEAD refers to the tip revision on the trunk, _except_ for
!  *  "cvs diff".  "cvs diff" interprets -rHEAD to mean the tip
!  *  revision of the current branch, however, that behavior is 
!  *  broken, because if the file has not been branched, that is,
!  *  the revision on the branch is the same one that's on the trunk
!  *  then the tip revision of the trunk is reported.  Also, it's
!  *  not clear (to me) what happens in the instance of a sticky
!  *  non-branch tag what -rHEAD is supposed to mean.  So, -rHEAD
!  *  is probably a lost cause, unless you redefine what it means.
!  *

from cvs.h, which I think is more correct...

So I need to fix that.

-- steve







__________________________________________________
Do You Yahoo!?
Send instant messages with Yahoo! Messenger.
http://im.yahoo.com/

Reply via email to