On Wed, Apr 29, 2015 at 11:16:37AM -0400, Barak Korren wrote: > Patch does not pass pyflakes: > > ./tests/samplingTests.py:30: 'libvirtconnection' imported but unused > ./tests/samplingTests.py:36: 'MonkeyPatch' imported but unused > make: *** [pyflakes] Error 1 > > You could clearly see that the tests did not pass for patchset #6 > Please do not merge patches with failing tests!
Barak, thanks for reporting this mistake of ours. https://gerrit.ovirt.org/#/c/40408/ would fix it momentarily. I believe that it stems from two reasons: - Ido did not run `make check` or `make pyflakes` before ticking "verified" on the patch - I failed to wait for the jenkins job to finish. To make sure that this does not repeat I should avoid merging freshly-posted patches. Ido should take better care for pep8 and pyflakes. I have vim plugins that help me avoid such mistakes I hear that http://www.vim.org/scripts/script.php?script_id=4440 is better than what I actually have. Regards, Dan. _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra