On 9/30/19 9:24 AM, Luca BRUNO wrote:
> This tweaks project-owners RBAC to allow updating a build, in order
> to make `cancel-build` work.
> 
> Ref: https://pagure.io/fedora-infrastructure/issue/8005
> Signed-off-by: Luca BRUNO <luca.br...@coreos.com>
> ---
>  roles/openshift/project/templates/role-appowners.yml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/roles/openshift/project/templates/role-appowners.yml 
> b/roles/openshift/project/templates/role-appowners.yml
> index bb4db5d9e..3cb94c542 100644
> --- a/roles/openshift/project/templates/role-appowners.yml
> +++ b/roles/openshift/project/templates/role-appowners.yml
> @@ -79,8 +79,10 @@ rules:
>    attributeRestrictions: null
>    resources:
>    - buildconfigs/instantiate
> +  - builds
>    verbs:
>    - create
> +  - update
>  - apiGroups:
>    - "*"
>    attributeRestrictions: null
> 


From a trivial review this LGTM but it would be really nice to get
someone who wrote this file to review the change!

Dusty
_______________________________________________
infrastructure mailing list -- infrastructure@lists.fedoraproject.org
To unsubscribe send an email to infrastructure-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org

Reply via email to