On 27/10/02 20:51 -0500, Patrick LeBoutillier wrote:
> This should do it, it tested fine on Win95 + Linux:
>
> -----8<-----
> 1187c1187
> < _rmtree(File::Spec->catdir($prefix,$rmpath));
> ---
> > _rmtree(File::Spec->catdir($prefix ? ($prefix,$rmpath) : $rmpath));
> 1191c1191
> < $rmpath = File::Spec->catdir($prefix,@parts);
> ---
> > $rmpath = File::Spec->catdir($prefix ? ($prefix,@parts) : @parts);
> ----8<-----
>
>
> BTW, if you want Inline to make "out of the box" on Win95/98/Me, you can add
> this at the end
> of Makefile.PL:
Thanks, applied. (With Rob's suggesestions and my formatting :)
Cheers, Brian
>
> -----8<-----
> if ($^O eq 'MSWin32'){
> print "\nFixing Makefile for Win95/98/Me...\n" ;
> open(MAKEFILE, "<Makefile") or die "Can't open Makefile for reading" ;
> my @lines = <MAKEFILE> ;
> close(MAKEFILE) ;
> open(MAKEFILE, ">Makefile") or die "Can't open Makefile for writing" ;
> foreach my $line (@lines){
> if ($line !~ /^\s*((\@\[)|(\]))\s*$/){
> print MAKEFILE $line ;
> }
> }
> close(MAKEFILE) ;
>
> }
> -----8<-----
>
> Then again I may be the only one out there actually doing some
> Perl development on Win95...
>
>
> Cheers,
>
> Patrick
> ----------------------------------
> | Patrick LeBoutillier
> | [EMAIL PROTECTED]
>
>
>
>
>
> >From: Brian Ingerson <[EMAIL PROTECTED]>
> >To: Patrick LeBoutillier <[EMAIL PROTECTED]>
> >CC: [EMAIL PROTECTED]
> >Subject: Re: Inline-0.44-RELEASE-CANDIDATE-1 - minor Win32 bug
> >Date: Sat, 26 Oct 2002 13:50:45 -0700
> >
> >On 26/10/02 10:08 -0400, Patrick LeBoutillier wrote:
> > > Hi,
> > >
> > > Found a very minor backwards compatibility bug with
> > > Inline-0.44-RELEASE-CANDIDATE-1.
> > >
> > > This used to work on Win32 but is broken now:
> > >
> > > rmpath('', 'd:\inline') ;
> > >
> > > File::Spec's catdir fields '\d:\inline'...
> > >
> > > I definitely admit this is a debatable use of the rmpath function, but
> > > I think having a way to nuke an already fully constructed path
> > > is necessary.
> > >
> > > Let me know what you think...
> >
> >Do you have time to patch this?
> >
> >Cheers, Brian
>
>
> _________________________________________________________________
> Get a speedy connection with MSN Broadband.� Join now!
> http://resourcecenter.msn.com/access/plans/freeactivation.asp
