Hello Ho, This sounds like more good news!
The patch is very much appreciated. The ideal way to submit a patch is through the gerrit code review system. More information can be found out about that here: http://www.itk.org/Wiki/ITK/Git/Develop Please let us know if you have any problems pushing the patch to gerrit! Thanks again! Brad On Aug 17, 2012, at 2:13 PM, Ho Cheung wrote: > Please see attached my patch to make ITK build correctly in VS2012. > > Everything looks like it built correctly and most of the tests passed with > only 2 tests failing. http://open.cdash.org/buildSummary.php?buildid=2521137 > > This patch is needed apparently because one of the other STL headers that ITK > used to depend on no longer includes "functional". > > See comment made on 21 Jun 2012 6:15 PM from Stephen T. Lavavej - MSFT > regarding this issue. > > Regards, > > Ho Cheung > Research Assistant > Bio-Image Analytics Lab - University of Houston > [email protected] > Cell: (832) 215-6347 > > > On Fri, Aug 17, 2012 at 10:09 AM, Ho Cheung <[email protected]> wrote: > The build was submitted. It looks like all the errors are related to > std::greater being used without #include <functional>. > > I'm currently adding in all the required headers and then I'll resubmit the > build and then if that is fine, I'll go ahead and make patch so you guys can > put it through the review process. > > > Regards, > > Ho Cheung > Research Assistant > Bio-Image Analytics Lab - University of Houston > [email protected] > Cell: (832) 215-6347 > > > On Fri, Aug 17, 2012 at 9:52 AM, douglas souza <[email protected]> wrote: > Do the wraps for Python + GCCXML work on that ? I am strugling with the > patches to make that work for VS10 in 64bit environement. > > Nice job.. > > Doug > > On Fri, Aug 17, 2012 at 9:59 AM, Ho Cheung <[email protected]> wrote: > Actually that build was without BUILD_TESTING or BUILD_EXAMPLES on. It was > built in that configuration so I could use it in my project (which requires > neither). > > I've ripped the script off one of the existing dashboard machines and > currently submitting a Nightly build with Examples and Testing on. There's > some exclamation marks which indicates errors. We should know what they are > in an hour or two. > > Regards, > > Ho Cheung > Research Assistant > Bio-Image Analytics Lab - University of Houston > [email protected] > Cell: (832) 215-6347 > > > On Fri, Aug 17, 2012 at 7:24 AM, Bradley Lowekamp <[email protected]> > wrote: > Great! > > I see that the build was successful at the bottom. So that is very good news! > Did you have the opportunity to run the tests too? > > Thanks for post this! > > Brad > > On Aug 17, 2012, at 7:48 AM, Ho Cheung wrote: > >> Hi Brad, >> >> My build submission machine is currently undergoing hardware maintenance >> (video card broke), but I'll put up a Nightly and Continuous build as soon >> as I get the RMA back. >> >> But for now I've attached a screenshot and the build-log of ALL_BUILD using >> Release and Debug done on my workstation >> >> <ITK-VS2012.txt> >> <ITK-VS2012.png> >> >> >> >> Regards, >> >> Ho Cheung >> Research Assistant - University of Houston >> [email protected] >> (832) 215-6347 >> >> On Aug 16, 2012, at 8:00 AM, Bradley Lowekamp <[email protected]> wrote: >> >>> Hello, >>> >>> I just read that MS Visual Studio 2012 is available for download: >>> >>> Visual Studio 2012 and Windows 8 Released to Developers >>> >>> I am wondering if any one has tried to compile ITK with this new compiler >>> yet? I tried one of the early beta releases but, I got some internal >>> compiler errors. I am hoping that they have fixed it. >>> >>> Brad. >>> >>> ======================================================== >>> Bradley Lowekamp >>> Medical Science and Computing for >>> Office of High Performance Computing and Communications >>> National Library of Medicine >>> [email protected] >>> >>> >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Kitware offers ITK Training Courses, for more information visit: >>> http://kitware.com/products/protraining.php >>> >>> Please keep messages on-topic and check the ITK FAQ at: >>> http://www.itk.org/Wiki/ITK_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://www.itk.org/mailman/listinfo/insight-developers >> > > > ======================================================== > Bradley Lowekamp > Medical Science and Computing for > Office of High Performance Computing and Communications > National Library of Medicine > [email protected] > > > > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.itk.org/mailman/listinfo/insight-developers > > > > > <VS2012_include_functional.patch> ======================================================== Bradley Lowekamp Medical Science and Computing for Office of High Performance Computing and Communications National Library of Medicine [email protected]
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
