All, I agree that BUILD_ALL_MODULES is currently deceptive.
I do like the idea of changing this to BUILD_DEFUALT_MODULES, then have a CMAKE error issued if BUILD_ALL_MODULES is explicitly set from some super build system. Hans On 12/18/12 5:28 PM, "Bill Lorensen" <[email protected]> wrote: >Maybe it should be BUILD_DEFAULT_MODULES? > >I agree that BUILD_ALL_MODULES is deceptive. > >On Tue, Dec 18, 2012 at 5:13 PM, Sean McBride <[email protected]> >wrote: >> Bill, >> >> Indeed. But what I meant is that the name "ITK_BUILD_ALL_MODULES" is >>rather deceptive (reminds me of -Wall). Perhaps it should be named >>ITK_BUILD_MOST_MODULES or ITK_BUILD_COMMON_MODULES is what I was getting >>at. >> >> Sean >> >> >> On Tue, 18 Dec 2012 12:02:38 -0500, Bill Lorensen said: >> >>>Sean, >>> >>>It is not on by default. >>> >>>Bill >>> >>>On Tue, Dec 18, 2012 at 11:11 AM, Sean McBride <[email protected]> >>>wrote: >>>> On Tue, 18 Dec 2012 15:48:40 +0000, Williams, Norman K said: >>>> >>>>>I should have caught this but like you I didn't have PHilipsRecImageIO >>>>>turned on. >>>>> >>>>>Is there a good reason not to have this ON by default? And I'm all >>>>>for >>>>>making all the factory builds turn on everything that's practical to >>>>>turn >>>>>on. >>>> >>>> I'd like to turn it on on my dashboards, as I use that code. In fact, >>>I had assumed it was on. I have ITK_BUILD_ALL_MODULES=1, but apparently >>>that doesn't mean what I thought... >> >> > > > >-- >Unpaid intern in BillsBasement at noware dot com >_______________________________________________ >Powered by www.kitware.com > >Visit other Kitware open-source projects at >http://www.kitware.com/opensource/opensource.html > >Kitware offers ITK Training Courses, for more information visit: >http://kitware.com/products/protraining.php > >Please keep messages on-topic and check the ITK FAQ at: >http://www.itk.org/Wiki/ITK_FAQ > >Follow this link to subscribe/unsubscribe: >http://www.itk.org/mailman/listinfo/insight-developers ________________________________ Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you. ________________________________ _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
