Interesting thing OpenJpeg was upgraded to utilize CMake by Mathieu Malaterre. Hopefully that will make things easier.
I think we need to be better about keeping some of our libraries up to date. So I am aware of the git subtree merge, when you have another git repository for a sub project. I recall a simular technique for when the imported code if from a tarball. Any one have a link to some documentation on that? Thanks, Brad On May 23, 2013, at 8:09 AM, Bradley Lowekamp <[email protected]> wrote: > Hi, > > I will suppose then that the best corse of action is to upgrade the openjpeg > library. > > Is there any particular advice for this upgrade? Or is just dropping in the > new code likely going to work? > > Thanks, > Brad > > On May 22, 2013, at 4:26 PM, Bradley Lowekamp <[email protected]> wrote: > >> Hello, >> >> I was going over some failing tests on windows debug systems, that are >> getting forgotten. Some of them are related to JPEG 2000. This is an >> interesting on. >> >> This library is compiled a "C" library yet we use it from c++. The size of >> the bool type is not matching up on either size on C++ is a byte, while on C >> is an int. >> >> You can see how this unfortunately happens here: >> >> https://github.com/Kitware/ITK/blob/master/Modules/ThirdParty/OpenJPEG/src/openjpeg/openjpeg.h#L50 >> >> It appears they have fixed this in the latest OpenJPEG 1.5.1 release... >> >> What should be do? >> >> Brad >> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://www.itk.org/mailman/listinfo/insight-developers > _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
