Kent, That patch does effect a compiler in debug mode. There was an assert which fails due to out of bounds access.
It should be included. Brad On Jul 10, 2013, at 10:55 AM, Matt McCormick <[email protected]> wrote: > On Wed, Jul 10, 2013 at 2:45 PM, Williams, Norman K > <[email protected]> wrote: >> I guess I haven't paid attention to the release branch process. I'm >> guessing certain changes get cherry picked in and then get tested all >> mashed up together? > > Ideally, they get merged into release as we go by the developer > notifying me on Gerrit when a patch should be on the release branch. > I will then merge on release and merge release into master. > Cherry-picking from master to release is a work-around when this does > not happen. > >> >> The std::string fix is actually a fix to MetaIO, checked in to the MetaIO >> SVN repo, and then pulled in by a robot. >> >> It fixes something that's ridiculous code, but wouldn't actually affect >> program execution. > > Thanks for the input-- I will leave it off release, then. > > Thanks, > Matt > > > >> >> -- >> Kent Williams [email protected] >> >> >> >> >> >> >> On 7/10/13 7:41 AM, "Bradley Lowekamp" <[email protected]> wrote: >> >>> Matt, >>> >>> Looks like you got most of them. Here is another important one: >>> >>> commit 6d5b785c185b849d2287ff1a9903ed238ed6b7e9 >>> Author: Kent Williams <[email protected]> >>> Date: Thu Jun 13 09:30:16 2013 -0400 >>> >>> ENH: fix std::string usage >>> >>> What about this one? >>> df66144 BUG: ImageSeriesWriter + GDCMImageIO loses info >>> >>> Brad >>> >>> On Jul 9, 2013, at 5:26 PM, Matt McCormick <[email protected]> >>> wrote: >>> >>>> Others identified: >>>> >>>> Bradley Lowekamp (5): >>>> BUG: disable aligned attribute for GCC 4.1 >>>> BUG: Prevent signed integer overflow in vnl urand_ >>>> BUG: enable return value optimzation for VS debug mode >>>> BUG: fix gradient recusive gaussian in VS debug >>>> BUG: in NthElementAdaptor pass by reference to modify argument >>>> >>>> Daniel Maleike (1): >>>> BUG: Assert unchanged pixels only for non-PALETTE_COLOR images >>>> >>>> Mark Hiner (1): >>>> BUG: Wrong classpath separator on Windows >>>> >>>> Martin Müllenhaupt (1): >>>> COMP: host platform source dir check >>>> >>>> Matthew McCormick (1): >>>> BUG: Remove non-existant GeSignaHDx data references. >>>> >>>> >>>> >>>> On Tue, Jul 9, 2013 at 9:03 PM, Matt McCormick >>>> <[email protected]> wrote: >>>>> Also added per Brad L's recommendation: >>>>> >>>>> 1a3fef2 BUG: VS10/11 debug assertions for null pointer for std::copy. >>>>> >>>>> >>>>> >>>>> On Tue, Jul 9, 2013 at 8:33 PM, Matt McCormick >>>>> <[email protected]> wrote: >>>>>> Hi all, >>>>>> >>>>>> Are there are any patches in the master branch that should also be in >>>>>> the release branch for a 4.4.1 bug fix release? These should be >>>>>> critical, low-risk patches that fix build issues, behavior, etc. >>>>>> >>>>>> So far, we have: >>>>>> >>>>>> df66144 BUG: ImageSeriesWriter + GDCMImageIO loses info >>>>>> 1fed73108f BUG: VS11 Debug mode assertions fixes >>>>>> >>>>>> Thanks, >>>>>> Matt >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Kitware offers ITK Training Courses, for more information visit: >>> http://kitware.com/products/protraining.php >>> >>> Please keep messages on-topic and check the ITK FAQ at: >>> http://www.itk.org/Wiki/ITK_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://www.itk.org/mailman/listinfo/insight-developers >> >> >> >> ________________________________ >> Notice: This UI Health Care e-mail (including attachments) is covered by the >> Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential >> and may be legally privileged. If you are not the intended recipient, you >> are hereby notified that any retention, dissemination, distribution, or >> copying of this communication is strictly prohibited. Please reply to the >> sender that you have received the message in error, then delete it. Thank >> you. >> ________________________________ _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
