Hi Kent, My vote is of course for B) -- we can add it to ITK's release branch soon after, and Slicer can use the updated release branch SHA.
Thanks, Matt On Fri, Sep 20, 2013 at 9:25 PM, Williams, Norman K <[email protected]> wrote: > If I was just proposing a change to ITK this would be a bit easier -- I'd > just go through ITK's gerrit review system. > > As it is this has a few more moving parts. > > The problem was that MGHImageIO was writing out Image origins incorrectly. > Eun Young Kim discovered this while using SimpleITK within Slicer to read > and write MGZ files. > > I re-wrote the 'WriteHeader' code where it converts the origin from ITK > conventions to FreeSurfer conventions, so the conversion code on the Write > side matches that on the Read side. > > But getting this incorporated back into Slicer and ITK has more than one > step. > > ITK: > 1. Merge the pull request into the Slicer/itkMGHImageIO repository on > github. The pull request is here: > https://github.com/Slicer/itkMGHImageIO/pull/3 > 2. Get a topic through ITK Gerrit to update the SHA to match the revision > of my change. > > SLICER: > > Slicer has an older version of MGHImageIO than the one used by ITK; I > don't know if Slicer uses this and turns on the MGHImageIO remote module > when it builds ITK. > A) If Slicer uses the old code in Slicer/Libs/MGHImageIO, then this should > be replaced by the code in the Github repository above. > B) If Slicer uses the ITK version via the ITK remote module for > itkMGHImageIO, then Š well there's a bit of a problem, as when the fix > gets propogated through into ITK, it will be at the Development head for > ITK, and be some time before it's part of a ITK Minor version release. > Slicer no doubt picks a particular ITK version and sticks with it until a > newer version comes along with sufficient new functionality and bug fixes > to justify re-validating ITK all over again with Slicer. > > So I have the fix, I just need to know what I need to do for it to be > pushed where it needs to be. > > > -- > Kent Williams [email protected] > > > > > > > ________________________________ > Notice: This UI Health Care e-mail (including attachments) is covered by the > Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential > and may be legally privileged. If you are not the intended recipient, you > are hereby notified that any retention, dissemination, distribution, or > copying of this communication is strictly prohibited. Please reply to the > sender that you have received the message in error, then delete it. Thank > you. > ________________________________ > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.itk.org/mailman/listinfo/insight-developers _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
