The patch has been merged to correct the failures. Thanks for the reviews.
Sorry that the original patch was merged -- I thought the CDash@Home versions were not picking up the correct version, and I verified manually with a Visual Studio build. Unfortunately, Visual Studio 2010 does not have the same issues as 2008. Following a good dashboard tomorrow, I'll backport to the release branch. Thanks, Matt On Mon, Jan 20, 2014 at 9:52 AM, Bradley Lowekamp <[email protected]> wrote: > Bill also note that MINC didn't compile on windows for the release. I would > also hope that we will have a good patch for MINC for the release branch for > the patch release shortly. > > Brad > On Jan 20, 2014, at 9:28 AM, Bill Lorensen <[email protected]> wrote: > >> I think we should merge http://review.source.kitware.com/#/c/14079/ ASAP. >> >> >> On Mon, Jan 20, 2014 at 9:17 AM, Brian Helba <[email protected]> wrote: >>> It appears as though patch: http://review.source.kitware.com/#/c/14023/ is >>> the culprit. It was merged with a red dashboard, apparently under the >>> assumption that the dashboard client was unreliable. More evidence for this >>> is the CDash nightly build for "dash5win7x64.kitware": it's clean on the >>> 14th and starts failing on the 16th, the same day that the aforementioned >>> patch was merged. >>> >>> I don't think it's necessary yet to remove MINC from the CDash@Home robot >>> builds, as we have 2 better options: revert the aforementioned patch ASAP, >>> or merge http://review.source.kitware.com/#/c/14079/ (which appears to be >>> coming back with clean builds) ASAP. The latter clearly looks like the >>> better option. >>> >>> Can we merge this right away, so further robot builds aren't tainted? >>> >>> >>> On Mon, Jan 20, 2014 at 9:04 AM, Bill Lorensen <[email protected]> >>> wrote: >>>> >>>> Folks, >>>> >>>> The gerrit build: dash5win7x64.kitware continues to fail to compile. >>>> This means that reviews of gerrit patches need to look at this failure >>>> log for each review. It appears the failures are MINC related. ALso, >>>> two nightly machines are failing with the same compile errors. >>>> >>>> Can someone take a look at these or at least remove MINC from the >>>> gerrit robot build. >>>> >>>> Bill >>>> _______________________________________________ >>>> Powered by www.kitware.com >>>> >>>> Visit other Kitware open-source projects at >>>> http://www.kitware.com/opensource/opensource.html >>>> >>>> Kitware offers ITK Training Courses, for more information visit: >>>> http://kitware.com/products/protraining.php >>>> >>>> Please keep messages on-topic and check the ITK FAQ at: >>>> http://www.itk.org/Wiki/ITK_FAQ >>>> >>>> Follow this link to subscribe/unsubscribe: >>>> http://www.itk.org/mailman/listinfo/insight-developers >>>> _______________________________________________ >>>> Community mailing list >>>> [email protected] >>>> http://public.kitware.com/cgi-bin/mailman/listinfo/community >>> >>> >>> >>> >>> -- >>> Brian Helba >>> Medical Imaging >>> Kitware, Inc. >> >> >> >> -- >> Unpaid intern in BillsBasement at noware dot com >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://www.itk.org/mailman/listinfo/insight-developers > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.itk.org/mailman/listinfo/insight-developers > _______________________________________________ > Community mailing list > [email protected] > http://public.kitware.com/cgi-bin/mailman/listinfo/community _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
