Luis, I noticed some of this too,
I began poking at it here: http://review.source.kitware.com/#/c/13646/2/Modules/Filtering/LabelMap/test/CMakeLists.txt There are also some tests, which are not even being compiled. When I tried wrapping some of these filters in SimpleITK I got a bunch of segfaults, then I looked and saw they had no coverage :( Regarding coverage, I have just gotten SimpleITK up to 91.45%. Brad On Feb 13, 2014, at 7:48 PM, Luis Ibanez <[email protected]> wrote: > It seems that when some of the LabelMap filters were moved > out of the Review directory and into the module > > Filtering/LabelMaps > > Their .cxx test files were properly moved, but they were not > added to the corresponding CMakeLists.txt file. > > > As a consequence, > > from the 95 files that have the lowest coverage in ITK: > > http://open.cdash.org/viewCoverage.php?buildid=3218139 > > > 27 of them are LabelMap classes: > > itkShapeUniqueLabelMapFilter.h > itkBinaryStatisticsOpeningImageFilter.hxx > itkBinaryStatisticsKeepNObjectsImageFilter.hxx > itkBinaryShapeKeepNObjectsImageFilter.hxx > itkLabelStatisticsKeepNObjectsImageFilter.hxx > itkLabelStatisticsOpeningImageFilter.hxx > itkLabelShapeKeepNObjectsImageFilter.hxx > itkLabelShapeOpeningImageFilter.hxx > itkStatisticsRelabelImageFilter.hxx > itkShapeRelabelImageFilter.hxx > itkBinaryStatisticsKeepNObjectsImageFilter.h > itkBinaryStatisticsOpeningImageFilter.h > itkBinaryShapeKeepNObjectsImageFilter.h > itkLabelStatisticsKeepNObjectsImageFilter.h > itkShapeUniqueLabelMapFilter.hxx > itkLabelStatisticsOpeningImageFilter.h > itkLabelShapeKeepNObjectsImageFilter.h > itkStatisticsRelabelImageFilter.h > itkLabelShapeOpeningImageFilter.h > itkStatisticsOpeningLabelMapFilter.hxx > itkStatisticsKeepNObjectsLabelMapFilter.hxx > itkShapeRelabelImageFilter.h > itkStatisticsRelabelLabelMapFilter.hxx > itkStatisticsUniqueLabelMapFilter.hxx > itkStatisticsLabelObjectAccessors.h > itkObjectByObjectLabelMapFilter.h > itkStatisticsLabelObject.h > > > Here is an example of a fix for the code coverage of the > ShapeUniqueLabelMapFilter: > > http://review.source.kitware.com/#/c/14427/ > > > > > The next batch of classes with the lowest code coverage > in the toolkit are the following 24 files from the FEM framework: > > FEM/src/itkFEMElement3DC0LinearTriangular.cxx > FEM/src/itkFEMLoadPoint.cxx > FEM/src/itkFEMElement3DC0LinearTriangularLaplaceBeltrami.cxx > FEM/src/itkFEMLoadNoisyLandmark.cxx > FEM/src/itkFEMElement2DC0LinearLineStress.cxx > FEM/include/itkFEMElement3DMembrane1DOF.hxx > FEM/src/itkFEMElement2DC0QuadraticTriangularStrain.cxx > FEM/src/itkFEMElement2DC0QuadraticTriangularStress.cxx > FEM/src/itkFEMElement3DC0LinearHexahedronStrain.cxx > FEM/src/itkFEMElement2DC0LinearQuadrilateralStress.cxx > FEM/src/itkFEMElement2DC0LinearQuadrilateralStrain.cxx > FEM/src/itkFEMElement3DC0LinearTriangularMembrane.cxx > FEM/src/itkFEMElement3DC0LinearTetrahedronStrain.cxx > FEM/src/itkFEMElement3DC0LinearTetrahedronMembrane.cxx > FEM/src/itkFEMElement2DC0LinearTriangularMembrane.cxx > FEM/src/itkFEMElement2DC0LinearTriangularStrain.cxx > FEM/src/itkFEMElement2DC0LinearTriangularStress.cxx > FEM/src/itkFEMLinearSystemWrapper.cxx > FEM/src/itkFEMLoadElementBase.cxx > FEM/src/itkFEMElement2DC1Beam.cxx > FEM/src/itkFEMElement2DC0LinearLine.cxx > FEM/src/itkFEMElement2DC0LinearTriangular.cxx > FEM/src/itkFEMElement2DC0QuadraticTriangular.cxx > FEM/src/itkFEMLoadLandmark.cxx > > > > Raising code coverage is an ideal task for new developers > who want to get familiar with the system. > > > I'll be happy to mentor any ITK community member who would > like to help improve the code coverage of the toolkit, and in the > process become more familiar with the developing practices > of ITK. > > > Any takers ? :-) > > > In the meantime, > I'll be taking care of one of these files per day. > > > Luis > > > _______________________________________________ > Powered by www.kitware.com > > Visit other Kitware open-source projects at > http://www.kitware.com/opensource/opensource.html > > Kitware offers ITK Training Courses, for more information visit: > http://kitware.com/products/protraining.php > > Please keep messages on-topic and check the ITK FAQ at: > http://www.itk.org/Wiki/ITK_FAQ > > Follow this link to subscribe/unsubscribe: > http://www.itk.org/mailman/listinfo/insight-developers
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://www.itk.org/mailman/listinfo/insight-developers
