Done. http://review.source.kitware.com/16452
On Wed, Jul 30, 2014 at 3:00 PM, Bradley Lowekamp <[email protected]> wrote: > Sorry about that. It looks like KWsys aslo uses gerrit, so similar process > there: > http://www.itk.org/Wiki/KWSys/Git/Develop > > It seems like a good candidate for the release branch. Once merged into > KWSys, we'll see if it smoothly merged into ITK's release branch. > > Brad > > On Jul 30, 2014, at 8:56 AM, Rashad M <[email protected]> wrote: > > Hello Brad, > > Already in [1] > > *(If your change modifies the "Modules/ThirdParty/KWSys/src/KWSys" > directory please contribute directly to KWSys > <http://www.itk.org/Wiki/KWSys/Git>instead.)* > > So should continue in itk gerrit or KWSys?. If ITK it should be in release > branch or trunk (4.7). AFAICT, this happens to block build on MingW64 bit > on windows > > > [1] http://www.itk.org/Wiki/ITK/Git/Develop > > > On Wed, Jul 30, 2014 at 2:49 PM, Bradley Lowekamp <[email protected]> > wrote: > >> Hello, >> >> Could you please submit your patch to gerrit for review: >> >> http://www.itk.org/Wiki/ITK/Git/Develop >> >> Thanks, >> Brad >> >> >> >> On Jul 29, 2014, at 9:58 PM, Rashad M <[email protected]> wrote: >> >> Hi all, >> >> Building ITK with MinGW64 comes clean but when using it in other library >> gives the below error. Turning -fpermissive can solve this bug but its not >> a option to be considered. >> >> I had attached a patch which will resolve this issue. >> >> [ 78%] Building CXX object >> Code/ApplicationEngine/CMakeFiles/OTBApplicationEngine.dir/otbWrapperApplicationRegistry.cxx.obj >> [ 79%] Building CXX object >> Code/ApplicationEngine/CMakeFiles/OTBApplicationEngine.dir/otbWrapperChoiceParameter.cxx.obj >> Linking CXX shared library ../../bin/libOTBTesting.dll >> [ 79%] Built target OTBTesting >> [ 79%] Building CXX object >> Code/ApplicationEngine/CMakeFiles/OTBApplicationEngine.dir/otbWrapperInputImageListParameter.cxx.obj >> [ 79%] Building CXX object >> Code/ApplicationEngine/CMakeFiles/OTBApplicationEngine.dir/otbWrapperOutputImageParameter.cxx.obj >> Scanning dependencies of target otbTestDriver >> [ 79%] Building CXX object >> Code/Testing/CMakeFiles/otbTestDriver.dir/otbTestDriver.cxx.obj >> In file included from >> /.../OTB-Nightly/Code/Testing/otbTestDriver.cxx:35:0: >> /home/rashad/packages/mxe/usr/x86_64-w64-mingw32.shared/include/ITK-4.6/itksys/SharedForward.h: >> In function 'void kwsys_shared_forward_execvp(const char*, const char* >> const*)': >> >> /home/rashad/packages/mxe/usr/x86_64-w64-mingw32.shared/include/ITK-4.6/itksys/SharedForward.h:516:19: >> error: invalid conversion from 'const char* const*' to 'char* const*' >> [-fpermissive] >> >> execvp(cmd, argv); >> ^ >> In file included from >> /home/rashad/packages/mxe/usr/x86_64-w64-mingw32.shared/include/ITK-4.6/itksys/SharedForward.h:158:0, >> from /.../OTB-Nightly/Code/Testing/otbTestDriver.cxx:35: >> >> >> -- >> Regards, >> Rashad >> <itk-3-execvp.patch>_______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/insight-developers >> _______________________________________________ >> Community mailing list >> [email protected] >> http://public.kitware.com/mailman/listinfo/community >> >> >> > > > -- > Regards, > Rashad > > > -- Regards, Rashad
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/insight-developers
