Hi Brad, Yes, that one (and its parent).
I did in fact pull the patch and compile it without any issues. I ran the related tests too, which passed. But it seemed to me that I couldn't give a "Verify" score alone and had to give a "Code Review" score as well. Matt's reply has made it clearer now. Thanks! On Thu, Sep 4, 2014 at 4:43 PM, Bradley Lowekamp <[email protected]> wrote: > Hello Girish, > > I assume you are talking about this patch: > http://review.source.kitware.com/#/c/16868/ > > Thanks again for contributing the patch which demonstrated the bug you > encountered. > > For this particular case I would encourage you to download, checkout, and > compile the patch and verify that is resolves the issue you initially > encountered. Then report back if it fixes the problem. > > Brad > > On Sep 4, 2014, at 11:29 AM, Girish Mallya Udupi <[email protected]> > wrote: > > > Hello, > > > > I have a couple of questions about the Gerrit review process - > > > > 1) Is the creator of a topic automatically added as a reviewer on > subsequent patches in the topic? > > > > 2) As a reviewer, if I am unable to understand the changes made to the > code (simply because I am not an advanced programmer), should I leave the > patch unscored? > > > > _______________________________________________ > > Powered by www.kitware.com > > > > Visit other Kitware open-source projects at > > http://www.kitware.com/opensource/opensource.html > > > > Kitware offers ITK Training Courses, for more information visit: > > http://kitware.com/products/protraining.php > > > > Please keep messages on-topic and check the ITK FAQ at: > > http://www.itk.org/Wiki/ITK_FAQ > > > > Follow this link to subscribe/unsubscribe: > > http://public.kitware.com/mailman/listinfo/insight-developers > > -- Regards, Girish
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/insight-developers
