Hans, Great, thanks for being so prompt an sneaking that patch in.
Brad On Nov 24, 2014, at 9:09 AM, Johnson, Hans J <[email protected]> wrote: > Brad, > > I think it was fixed last night. I submitted a patch, and Matt reviewed > and merged it. > > http://review.source.kitware.com/#/c/18135/ > > > Hans > > > > > -----Original Message----- > From: Bradley Lowekamp <[email protected]> > Date: Monday, November 24, 2014 at 7:58 AM > To: ITK <[email protected]> > Cc: Hans Johnson <[email protected]>, Matthew McCormick > <[email protected]> > Subject: Override keyword requirements: New transform compilation errors. > > Community Developers, > > Recently a number of builds that are running C++11 have been producing > errors when the override moniker is not used on derived method. This is > difficult for many contributors to ensure because this is new to C++11 and > those who are not compiling for that version of C++ are oblivious to this > potential error. > > Is it worth the effort to enforce this usage? Or should we try to see if > it can only be a warning? > > If we want to enforce it's usage then we will _need_ a cdash@home build > with this flag, so that we can check the gerrit builds. But I don't think > that we have additional cdash@home resources to additional builds. > > > Hans, > > There are some new compilation errors on the dashboard, related to > overriding the Transform::GetNumberOfParameteres: > http://open.cdash.org/viewBuildError.php?buildid=3585002 > > Please let us know if you need some help addressing these in a timely > fashion. > > Thanks, > Brad > > > > ________________________________ > Notice: This UI Health Care e-mail (including attachments) is covered by the > Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential > and may be legally privileged. If you are not the intended recipient, you > are hereby notified that any retention, dissemination, distribution, or > copying of this communication is strictly prohibited. Please reply to the > sender that you have received the message in error, then delete it. Thank > you. > ________________________________ _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/insight-developers
