On Fri, 28 Aug 2015 11:16:53 -0400, Matt McCormick said: >Hi Sean, > >In checking up on the dashboard, we recently have acquired 8 failing >tests on RogueResearch9 ?Mac10.6-gcc-rel-x86_64-static: > > https://open.cdash.org/viewTest.php?onlyfailed&buildid=3973444 > > >They started on August 18th, but there were many changes that day: > > https://open.cdash.org/index.php?project=Insight&date=20150818 > >and it is difficult to know the source of the problem. Could git >bisect please be run on that box or is there any other information to >help find the source of the issue?
Took a while to run, but: git bisect start git bisect good 27e871d35c12ff85c798359c87b1828ee6d55d48 git bisect bad 0d769889367c013836d43691d13091326d6a998d 9ea5521e0fd2ed30404a72c53b1bdb15ab51a057 is the first bad commit commit 9ea5521e0fd2ed30404a72c53b1bdb15ab51a057 Author: Alexander Leinoff <[email protected]> Date: Fri Aug 14 09:11:46 2015 -0500 COMP: Removes floating-point equality checks Equality checks between floating point values and other types are sometimes required to be exact and other times need only be approximate. Here direct equality checks are replaced with functions calls to either an exact or approximate comparison. Using these functions explicitly stating which kind of comparison is being requested improves clarity and readability of code, and removes compiler warnings ie. Wfloat-equal. Change-Id: I93241acc40178b50ab04158acfdbce5a93242890 :040000 040000 0875e6abbbbe9ae31f0e5992a25b8f17ef72ea8c 3bb3c0776a4e65c2a5dc35624b67f7a8e836c5fb M Examples :040000 040000 d8cbeb4d22f289a1c590b8cb43e4f05826e2c476 4e62bf45576ef2ff5b42326330b5eced60c4e367 M Modules Cheers, -- ____________________________________________________________ Sean McBride, B. Eng [email protected] Rogue Research www.rogue-research.com Mac Software Developer Montréal, Québec, Canada _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/insight-developers
