Hello, I made a patch for this issue, but I'm having trouble with gerrit-push over http (I'm behind a firewall and proxy):
$ git gerrit-push Fetching gerrit master Pushing to gerrit remote: Unauthorized fatal: Authentication failed for 'http://[email protected]/p/ITK/' Not sure why it's not working, I followed instructions from the wiki. Maybe it's related to the issue my colleague was having: http://permalink.gmane.org/gmane.comp.lib.itk.devel/3159 So here is a format-patch. Thanks, Victor Poughon ________________________________ De : Dženan Zukić [[email protected]] Envoyé : lundi 4 janvier 2016 17:23 À : Poughon Victor Cc : [email protected] Objet : Re: [ITK-dev] itkStaticAssert warnings with clang Hi Victor, this is an excellent opportunity for you to contribute<http://www.itk.org/Wiki/ITK/Contribute> to ITK the patch which fixes the described issue. Add Matt McCormick as one of the reviewers. Regards, Dženan On Mon, Jan 4, 2016 at 8:30 AM, Poughon Victor <[email protected]<mailto:[email protected]>> wrote: Hi all, I think there is an issue in itkStaticAssert causing a large number of warnings (199) when building with clang 3.5.0. Here is a clean dashboard build of the current master branch showing the warnings: https://open.cdash.org/viewBuildError.php?type=1&buildid=4174833 This was previously discussed on OTB's mailing list: https://groups.google.com/forum/#!searchin/otb-developers/itkStaticAssert/otb-developers/X8Bfvzh8g-A/T9basCNfCAAJ They are caused by __attribute__(error(str)) being used, which is a GCC specific attribute. I will quote my colleague Luc Hermitte: > clang defines GCC macros (__GNUC__ & all). > The #if should also test for !defined(__clang__). When building with this version of clang: clang version 3.5.0 (tags/RELEASE_350/final) Target: x86_64-redhat-linux-gnu Thread model: posix Happy 2016, Victor Poughon _______________________________________________ Powered by www.kitware.com<http://www.kitware.com> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/insight-developers
From 1f2de32442c057422d7b26dfafba85481e90d3b9 Mon Sep 17 00:00:00 2001 From: Victor Poughon <[email protected]> Date: Tue, 5 Jan 2016 10:17:19 +0100 Subject: [PATCH] COMP: fix itkStaticAssert warnings with clang++ clang defines GCC version macros. This patch fixes > warning: unknown attribute 'error' ignored being generated by clang when itkStaticAssert.h is included and restores fallback to the ITK_JOIN trick. Change-Id: I841df6d036349a678fbb4dcbb7a6af11db5fed0d --- Modules/Core/Common/include/itkStaticAssert.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/Core/Common/include/itkStaticAssert.h b/Modules/Core/Common/include/itkStaticAssert.h index de90a2f..995e08f 100644 --- a/Modules/Core/Common/include/itkStaticAssert.h +++ b/Modules/Core/Common/include/itkStaticAssert.h @@ -33,7 +33,7 @@ * \ingroup ITKCommon */ # define itkStaticAssert(expr, str) static_assert(expr, str) -#elif ((__GNUC__ * 100) + __GNUC_MINOR__ ) >= 403 +#elif ((__GNUC__ * 100) + __GNUC_MINOR__ ) >= 403 && !defined(__clang__) // GCC 4.3 is enough for this trick // But it restricts the static assertion to non global contexts (-> functions) # define itkStaticAssert(expr,str) \ -- 2.4.3
_______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/insight-developers
