Hi, Yes, these will be fixed in a follow-up patch.
Thanks, Matt On Thu, Jul 7, 2016 at 10:01 AM, Lowekamp, Bradley (NIH/NLM/LHC) [C] <[email protected]> wrote: > Matt, > > This patch looks like it is the source of a number of valgrind defects on the > ITK dashboard that need to be addressed. > > https://open.cdash.org/viewDynamicAnalysisFile.php?id=3934294 > > Brad > >> On Jul 7, 2016, at 9:57 AM, Matt McCormick <[email protected]> >> wrote: >> >> Following up, this issue was addressed in this patch: >> >> http://review.source.kitware.com/#/c/21296/ >> >> and pushed upstream here: >> >> https://github.com/vxl/vxl/pull/337 >> >> It will be included in the ITK 4.10.1 release. >> >> On Fri, Jul 1, 2016 at 4:45 AM, Tom Vercauteren <[email protected]> >> wrote: >>> Dear all, >>> >>> Sorry for the cross-posting but this refers to an issue linking both ITK and >>> VNL. >>> >>> In 2010, we identified a licensing issue with some code from vnl and at the >>> time Luis Ibanez fixed it from the ITK side: >>> https://issues.itk.org/jira/browse/HISTITK-1160 >>> >>> Luis notably rewrote the LSQR code: >>> https://github.com/InsightSoftwareConsortium/ITK/tree/release-3.20/Utilities/vxl/v3p/netlib/linalg >>> http://svn.na-mic.org/NAMICSandBox/trunk/SparseLinearSolverConversion/C++/ >>> https://github.com/InsightSoftwareConsortium/ITK/commits/release-3.20/Utilities/vxl/v3p/netlib/linalg >>> >>> It seems that this effort was not backported to VXL and was subsequently >>> lost when moving to ITK 4: >>> https://github.com/InsightSoftwareConsortium/ITK/tree/master/Modules/ThirdParty/VNL/src/vxl/v3p/netlib/linalg >>> >>> It would be great if someone could look into this (important) licensing >>> issue. >>> >>> For the only purpose of LSQR, I copied the LSQR NAMICSandBox code in a >>> standalone github repo here: >>> https://github.com/tvercaut/LSQR-cpp >>> >>> I have also added a comment in the ITK and VXL bug trackers: >>> https://issues.itk.org/jira/browse/HISTITK-1160 >>> https://github.com/vxl/vxl/issues/332 >>> >>> Best wishes, >>> Tom >>> >>> _______________________________________________ >>> Powered by www.kitware.com >>> >>> Visit other Kitware open-source projects at >>> http://www.kitware.com/opensource/opensource.html >>> >>> Kitware offers ITK Training Courses, for more information visit: >>> http://kitware.com/products/protraining.php >>> >>> Please keep messages on-topic and check the ITK FAQ at: >>> http://www.itk.org/Wiki/ITK_FAQ >>> >>> Follow this link to subscribe/unsubscribe: >>> http://public.kitware.com/mailman/listinfo/insight-developers >>> >> _______________________________________________ >> Powered by www.kitware.com >> >> Visit other Kitware open-source projects at >> http://www.kitware.com/opensource/opensource.html >> >> Kitware offers ITK Training Courses, for more information visit: >> http://kitware.com/products/protraining.php >> >> Please keep messages on-topic and check the ITK FAQ at: >> http://www.itk.org/Wiki/ITK_FAQ >> >> Follow this link to subscribe/unsubscribe: >> http://public.kitware.com/mailman/listinfo/insight-developers > _______________________________________________ Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Kitware offers ITK Training Courses, for more information visit: http://kitware.com/products/protraining.php Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/insight-developers
