On Mon, Jun 28, 2010 at 7:48 PM, Dave Airlie <airl...@gmail.com> wrote: > On Sat, Jun 12, 2010 at 7:21 PM, Andy Lutomirski <l...@mit.edu> wrote: >> Commit 7a772c492fcfffae812ffca78a628e76fa57fe58 has two bugs which >> made the hotplug problems on my laptop worse instead of better. >> >> First, it did not, in fact, disable the CRT plug interrupt -- it >> disabled all the other hotplug interrupts. It seems rather doubtful >> that that bit of the patch fixed anything, so let's just remove it. >> (If you want to add it back, you probably meant ~CRT_HOTPLUG_INT_EN.) >> >> Second, on at least my GM45, setting CRT_HOTPLUG_ACTIVATION_PERIOD_64 >> and CRT_HOTPLUG_VOLTAGE_COMPARE_50 (when they were previously unset) >> causes a hotplug interrupt about three seconds later. The old code >> never restored PORT_HOTPLUG_EN so this could only happen once, but >> they new code restores those registers. So just set those bits when >> we set up the interrupt in the first place. > > ping? Intel guys? ajax? anyone? > > We are clearly broken on GM45 at the moment. >
I dunno. This is all I've heard: http://www.mail-archive.com/dri-de...@lists.freedesktop.org/msg01433.html It's kind of an ACK :) Rafael has this in his tracker now, I think. --Andy _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx