On Fri, 18 Mar 2011 08:22:16 -0700, Keith Packard <kei...@keithp.com> wrote: > On Fri, 18 Mar 2011 08:02:09 +0000, Chris Wilson <ch...@chris-wilson.co.uk> > wrote: > > > A broken implementation of is_pot() prevented the detection of when a > > singular pipe was enabled. > > > - return mask && (mask & -mask) == 0; > > + return mask && (mask & -mask) == mask; > > I think the form > > mask && (mask & (mask - 1)) == 0 > > is easier to reason about.
I've reassigned authorship to Yuanhan and gone with your preferred form. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
