On Sat, Mar 19, 2011 at 07:55:01AM +0000, Chris Wilson wrote: > Let's make this a more generic function because it does look useful. > > static inline int intel_ring_wait_idle(struct intel_ring_buffer *ring) > { > return intel_wait_ring_buffer(ring, ring->space - 8); > }
Sounds good. I'm currently working this into a new patch in the series and putting it in intel_ringbuffer.c, as well as replacing two callers. > > Just report the failure in all cases and avoid jargon (if possible)! > > if (intel_ring_wait_idle(LP_RING(dev_priv))) { > DRM_ERROR("failed to enable automatic power saving\n"); > return; > } Why not do the teardown? This is was I was saying on IRC: in the GPU hang case we can safely free the bos. In the non-hang case, we can unsafely free them. As for the jargon, that's fine. > -- > Chris Wilson, Intel Open Source Technology Centre Ben _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx