On Sat, 16 Apr 2011 12:52:35 +0200, Daniel Vetter <dan...@ffwll.ch> wrote: > One small comment-nitpick below. > > > diff --git a/drivers/gpu/drm/i915/i915_gem.c > > b/drivers/gpu/drm/i915/i915_gem.c > > index 7271956..c73eeaf 100644 > > --- a/drivers/gpu/drm/i915/i915_gem.c > > +++ b/drivers/gpu/drm/i915/i915_gem.c > > @@ -3095,40 +3095,55 @@ int i915_gem_object_set_cache_level(struct > > drm_i915_gem_object *obj, > > } > > > > /* > > - * Prepare buffer for display plane. Use uninterruptible for possible flush > > - * wait, as in modesetting process we're not supposed to be interrupted. > > + * Prepare buffer for display plane (scanout, cursors, etc). > > + * Expects to be called from an uninterruptible phase (modesetting) and > > allows > > Shouldn't that be "Can be called from uninterruptible ..."
Yes, I misphrased. I was thinking along the lines that it should be able to cope with uninterruptible phases but not that it was mandatory. -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
