On Mon, 16 Jan 2012 11:57:54 -0800, Jesse Barnes <jbar...@virtuousgeek.org> wrote:
> Now that we're using the sprite WM fields, we need to take care not to > clobber them in the main update_wm functions. While we're at it, make > sure we mask out the old sprite wm value before or'ing in the new one > when the sprite wm is updated. > > Signed-off-by: Jesse Barnes <jbar...@virtuousgeek.org> Reviewed-by: Keith Packard <kei...@keithp.com> <bikeshed> Would avoid line wrapping with: > + val = I915_READ(WM0_PIPEA_ILK); > + val &= ~(WM0_PIPE_PLANE_MASK | WM0_PIPE_CURSOR_MASK); > + I915_WRITE(WM0_PIPEA_ILK, val | > + ((plane_wm << WM0_PIPE_PLANE_SHIFT) | cursor_wm)); + val = I915_READ(WM0_PIPEA_ILK); + val &= ~(WM0_PIPE_PLANE_MASK | WM0_PIPE_CURSOR_MASK); + val |= ((plane_wm << WM0_PIPE_PLANE_SHIFT) | cursor_wm); + I915_WRITE(WM0_PIPEA_ILK, val); </bikeshed> -- keith.pack...@intel.com
pgp4JNUrs4qBp.pgp
Description: PGP signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
