On Thu, 22 Mar 2012 08:45:32 -0700 Jesse Barnes <jbar...@virtuousgeek.org> wrote:
> On Wed, 21 Mar 2012 18:30:11 -0700 > Ben Widawsky <b...@bwidawsk.net> wrote: > > > On Wed, 21 Mar 2012 12:48:25 -0700 > > Jesse Barnes <jbar...@virtuousgeek.org> wrote: > > > > > From: Rohit Jain <rohit.j...@intel.com> > > > > > > Added support for parsing the OEM Customizable Modes Block (#20) > > > in the VBIOS table. > > > > > > Signed-off-by: Rohit Jain <rohit.j...@intel.com> > > > Reviewed-by: Shobhit Kumar <shobhit.ku...@intel.com> > > > Reviewed-by: Vijay A. Purushothaman > > > <vijay.a.purushotha...@intel.com> Acked-by: Jesse Barnes > > > <jesse.bar...@intel.com> Reviewed-by: Eugeni Dodonov > > > <eugeni.dodo...@intel.com> Signed-off-by: Artem Bityutskiy > > > <artem.bityuts...@linux.intel.com> Signed-off-by: Jesse Barnes > > > <jbar...@virtuousgeek.org> --- > > > > I'll be honest, I haven't read through the whole series yet, but I > > really don't see the point of this patch, at least in the next few > > patches. Could we modify the commit to describe why we need this (or > > drop it)? > > This one is unrelated to VLV, it's just extra VBT gravy. Obviously it > needs to stuff the mode info somewhere though... > THe HW can behave one in two ways, you read the info out and that is required to advance the internal state machine to get to the next info you care about. Or, you read the info out and nobody knows or cares. I truly don't know how this HW works yet, but I'd say if it's the former it should be added as a comment to the code. If it's the latter, we should drop the patch. $.02 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
