On 26/09/16 19:30, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > The global mode_config.rotation_property is going away, switch over to > per-plane rotation_property. > > Not sure I got the annoying crtc rotation_property handling right. > Might work, or migth not. > > v2: Drop the BIT() > Don't create rotation property twice for each primary plane > > Cc: Tomi Valkeinen <tomi.valkei...@ti.com> > Cc: Rob Clark <robdcl...@gmail.com> > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > ---
> diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c
> b/drivers/gpu/drm/omapdrm/omap_plane.c
> index 6ddaa5ea4b6b..b272f810989e 100644
> --- a/drivers/gpu/drm/omapdrm/omap_plane.c
> +++ b/drivers/gpu/drm/omapdrm/omap_plane.c
> @@ -211,9 +211,16 @@ void omap_plane_install_properties(struct drm_plane
> *plane,
> struct omap_drm_private *priv = dev->dev_private;
>
> if (priv->has_dmm) {
> - struct drm_property *prop = dev->mode_config.rotation_property;
> -
> - drm_object_attach_property(obj, prop, DRM_ROTATE_0);
> + if (!plane->rotation_property)
> + drm_plane_create_rotation_property(plane,
> + DRM_ROTATE_0,
> + DRM_ROTATE_0 |
> DRM_ROTATE_90 |
> + DRM_ROTATE_180 |
> DRM_ROTATE_270 |
> + DRM_REFLECT_X |
> DRM_REFLECT_Y);
> +
> + if (plane->rotation_property && obj != &plane->base)
> + drm_object_attach_property(obj,
> plane->rotation_property,
> + DRM_ROTATE_0);
I think this could use a short comment, as it's not obvious wth is going
on here =).
Otherwise both omap patches look fine, and test fine.
Reviewed-by: Tomi Valkeinen <tomi.valkei...@ti.com>
Tomi
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
