On pe, 2016-10-07 at 12:03 +0100, Chris Wilson wrote: > On Fri, Oct 07, 2016 at 01:27:12PM +0300, Joonas Lahtinen wrote: > > > > On pe, 2016-10-07 at 10:46 +0100, Chris Wilson wrote: > > > > > > @@ -324,14 +324,31 @@ submit_notify(struct i915_sw_fence *fence, enum > > > i915_sw_fence_notify state) > > > > > > struct drm_i915_gem_request *request = > > > > > > container_of(fence, typeof(*request), submit); > > > > > > struct intel_engine_cs *engine = request->engine; > > > > > > + struct intel_timeline *timeline; > > > > Bump the assignment to here for consistency. > > The timeline is a bit more interesting due to how we are operating on > both the request->timeline and engine->timeline, so I wanted it separate > and keep it with a reminder of the split.
Maybe add a comment or two then? I see no value in providing the "information" this way. Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
