On ke, 2017-02-08 at 16:54 +0000, Chris Wilson wrote: > We first wait for a request to be submitted to hw and assigned a seqno, > before we can wait for the hw to signal completion (otherwise we don't > know the hw id we need to wait upon). Whilst waiting for the request to > be submitted, we may exceed the user's timeout and need to propagate the > error back. > > Reported-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > Fixes: 4680816be336 ("drm/i915: Wait first for submission, before waiting for > request completion") > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com> > Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> > Cc: <drm-intel-fi...@lists.freedesktop.org> # v4.10-rc1+
<SNIP> > +++ b/drivers/gpu/drm/i915/i915_gem_request.c > @@ -1084,6 +1084,9 @@ long i915_wait_request(struct drm_i915_gem_request *req, > if (timeout < 0) > goto complete; > > + if (!timeout) > + return -ETIME; > + Misses the tracepoint, if that's deliberate; Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx