Chris Wilson <[email protected]> writes: > Prevent the overflow check from firing on machines with the full 4lvl > page tables, that are not restricted to GEN8_LEGACY_PDES. > > v2: Also fix the off-by-one in the compare > > Fixes: 894ccebee2b0 ("drm/i915: Micro-optimise gen8_ppgtt_insert_entries()") > Signed-off-by: Chris Wilson <[email protected]> > Cc: Mika Kuoppala <[email protected]> > Cc: Ville Syrjälä <[email protected]>
Reviewed-by: Mika Kuoppala <[email protected]> > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c > b/drivers/gpu/drm/i915/i915_gem_gtt.c > index 1f281554e4c9..b0ccc9b6c1c5 100644 > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c > @@ -854,7 +854,8 @@ gen8_ppgtt_insert_pte_entries(struct i915_hw_ppgtt *ppgtt, > break; > } > > - GEM_BUG_ON(pdpe > GEN8_LEGACY_PDPES); > + GEM_BUG_ON(!i915_vm_is_48bit(&ppgtt->base) && > + pdpe >= GEN8_LEGACY_PDPES); > pd = pdp->page_directory[pdpe]; > pde = 0; > } > -- > 2.11.0 > > _______________________________________________ > Intel-gfx mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
