On Fri, May 19, 2017 at 11:38:29AM +0300, Joonas Lahtinen wrote:
> On to, 2017-05-18 at 11:31 +0000, Michal Wajdeczko wrote:
> > Debugfs does not seems to be a right place to display transient data.
> > If we want to capture errors, we should log them.
> >
> > Signed-off-by: Michal Wajdeczko <michal.wajdec...@intel.com>
> > Cc: Chris Wilson <ch...@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
>
> <SNIP>
>
> > @@ -2482,7 +2482,6 @@ static void i915_guc_client_info(struct seq_file *m,
> > client->wq_size, client->wq_offset, client->wq_tail);
> >
> > seq_printf(m, "\tWork queue full: %u\n", client->no_wq_space);
>
> This seems like a valid candidate for removal too, the error will be
> propagated (although, -EINVAL seems odd, -ENOSPC might make more
> sense).
This removal is included in other patch:
[PATCH 3/6] drm/i915/guc: Remove GuC wq reservation
https://patchwork.freedesktop.org/patch/157088/
Michal
>
> Regards, Joonas
> --
> Joonas Lahtinen
> Open Source Technology Center
> Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
