On Mon, Sep 18, 2017 at 05:31:27PM +0000, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrj...@linux.intel.com> > > It is safe to call intel_psr_disable() on a platform without PSR. We > don't have such a check when calling intel_psr_enable() either. > > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > --- > drivers/gpu/drm/i915/intel_dp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 887953c0f495..d0ea9c4f87c8 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -2697,8 +2697,7 @@ static void intel_disable_dp(struct intel_encoder > *encoder, > if (old_crtc_state->has_audio) > intel_audio_codec_disable(encoder); > > - if (HAS_PSR(dev_priv) && !HAS_DDI(dev_priv))
By removing the !HAS_DDI you are now duplicating the psr_disable on all platforms but VLV/CHV. Maybe we should integrate that once for all and only call enable and disable in one place for all platforms before removing this check. But I agree HAS_PSR could be removed already. > - intel_psr_disable(intel_dp, old_crtc_state); > + intel_psr_disable(intel_dp, old_crtc_state); > > /* Make sure the panel is off before trying to change the mode. But also > * ensure that we have vdd while we switch off the panel. */ > -- > 2.13.5 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
