On 9/30/2017 10:36 PM, Sagar Arun Kamble wrote:


On 9/29/2017 11:11 PM, Michal Wajdeczko wrote:
We want to keep GuC functions together. While here move
send registers initialization to early init as this is
one time operation.

Signed-off-by: Michal Wajdeczko <michal.wajdec...@intel.com>
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Sagar Arun Kamble <sagar.a.kam...@intel.com>
<snip>
+void intel_guc_init_early(struct intel_guc *guc)
+{
+    intel_guc_ct_init_early(&guc->ct);
+
+    mutex_init(&guc->send_mutex);
+    guc->send = intel_guc_send_nop;
+    guc->notify = gen8_guc_raise_irq;
+    guc_init_send_regs(guc);
Better to address guc_init_send_regs move in new patch as discussed.
Otherwise overall patch looks good to me.
Please s/dev_priv/i915 in entire patch. Missed earlier.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to