On Tue, Nov 07, 2017 at 05:18:21PM +0100, Daniel Vetter wrote:
> Now that we have CI, and that pm_rpm fully passes (I guess the audio
> folks have implemented proper runtime pm for snd-hda, hooray, pls
> confirm) it's time to enable this again by default.
> 
> Real goal here is to have 1 configuration only that we fully support,
> instead of tons of different codes with every user/customer tuning it
> differently. And really, power stuff should work by default, and
> should be enabled by everywhere where it is save to do so.
> 
> v2: Completely new commit message, a few years passed since v1 ...
> 
> Cc: Takashi Iwai <ti...@suse.de>
> Cc: Liam Girdwood <liam.r.girdw...@intel.com>
> Cc: "Yang, Libin" <libin.y...@intel.com>
> Cc: "Lin, Mengdong" <mengdong....@intel.com>
> Cc: "Li, Jocelyn" <jocelyn...@intel.com>
> Cc: "Kaskinen, Tanu" <tanu.kaski...@intel.com>
> Cc: "Zanoni, Paulo R" <paulo.r.zan...@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vet...@intel.com>

lgtm,

Reviewed-by: David Weinehall <david.weineh...@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_runtime_pm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c 
> b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index 8315499452dc..dc24d008d8d4 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -3232,7 +3232,7 @@ void intel_runtime_pm_enable(struct drm_i915_private 
> *dev_priv)
>       struct pci_dev *pdev = dev_priv->drm.pdev;
>       struct device *kdev = &pdev->dev;
>  
> -     pm_runtime_set_autosuspend_delay(kdev, 10000); /* 10s */
> +     pm_runtime_set_autosuspend_delay(kdev, 100);
>       pm_runtime_mark_last_busy(kdev);
>  
>       /*
> @@ -3251,6 +3251,8 @@ void intel_runtime_pm_enable(struct drm_i915_private 
> *dev_priv)
>               pm_runtime_use_autosuspend(kdev);
>       }
>  
> +     pm_runtime_allow(kdev);
> +
>       /*
>        * The core calls the driver load handler with an RPM reference held.
>        * We drop that here and will reacquire it during unloading in
> -- 
> 2.15.0.rc2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to