Quoting Chris Wilson (2017-11-15 10:50:35)
> clang spots
> 
> drivers/gpu/drm/i915/intel_pm.c:4655:6: warning: variable 'trans_min' is used 
> uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
>         if (INTEL_GEN(dev_priv) >= 10)
> 
> but fortunately for us we skip the function unless on a gen10+ device.
> However, to keep the function generic in case we do want to re-enable it
> for gen9 again, initialise trans_min to 0.
> 
> References: ca47667f523e ("drm/i915/gen10: Calculate and enable transition 
> WM")
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Mahesh Kumar <mahesh1.ku...@intel.com>
> Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
> Cc: Jani Nikula <jani.nik...@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.v...@intel.com>
> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com>

Forget this patch, the code is just wrong. But no fix sent yet!
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to