Quoting Jackie Li (2018-01-19 01:29:27) > intel_guc_reg.h should only include definition for GuC registers > and related register bits. GuC WOPCM related values should not > be defined in intel_guc_reg.h
GuC registers does not include GuC WOPCM? The code does seem to suggest they are related ;) > This patch creates a better file structure by moving GuC WOPCM > related definitions int to a new header intel_guc_wopcm.h > and moving GuC WOPCM related functions to a new source file > intel_guc_wopcm.c Just needs one more sentence to sell this, perhaps "as future patches will increase the complexity of determining the WOPCM layout". One function per file is just crying out for LTO ;) -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
