Quoting Chris Wilson (2018-06-05 10:34:20) > To spare ourselves a long line later, refactor the repeated check of > bind_count vs pin_count to a helper. > > Suggested-by: Joonas Lahtinen <[email protected]> > Signed-off-by: Chris Wilson <[email protected]> > Cc: Joonas Lahtinen <[email protected]> > Cc: Mika Kuoppala <[email protected]> > Cc: Matthew Auld <[email protected]> > --- > drivers/gpu/drm/i915/i915_vma.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c > index 9324d476e0a7..0b3de2f19e1c 100644 > --- a/drivers/gpu/drm/i915/i915_vma.c > +++ b/drivers/gpu/drm/i915/i915_vma.c > @@ -459,6 +459,17 @@ bool i915_gem_valid_gtt_space(struct i915_vma *vma, > unsigned long cache_level) > return true; > } > > +static void assert_bind_count(struct drm_i915_gem_object *obj) > +{ > + /* > + * Combine the assertion that the object is bound and that we have > + * pinned its pages. But we should never have pinned the pages
bound the object more than we have pinned its pages. That makes more sense. -Chris _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
