<snip>

diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h 
b/drivers/gpu/drm/i915/intel_guc_fwif.h
index 1a0f2a39cef9..8382d591c784 100644
--- a/drivers/gpu/drm/i915/intel_guc_fwif.h
+++ b/drivers/gpu/drm/i915/intel_guc_fwif.h
@@ -49,6 +49,7 @@
  #define   WQ_TYPE_BATCH_BUF           (0x1 << WQ_TYPE_SHIFT)
  #define   WQ_TYPE_PSEUDO              (0x2 << WQ_TYPE_SHIFT)
  #define   WQ_TYPE_INORDER             (0x3 << WQ_TYPE_SHIFT)
+#define   WQ_TYPE_NOOP                 (0x4 << WQ_TYPE_SHIFT)

I got general question to this ^ defines. Do I correctly see that PSEUDO and 
BATCH_BUF are not
used anywhere?


Yes they're unused. I'm assuming when the FW support was first added to i915 we just defined all the cases available in the FW at the time, even if we didn't actually use them. Personally I think it is worth keeping them as having only part of the modes defined would be less clear IMO.

Daniele
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to