== Series Details ==
Series: MST refcounting/atomic helpers cleanup (rev2)
URL : https://patchwork.freedesktop.org/series/54030/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f950c3fa3447 drm/dp_mst: Rename drm_dp_mst_get_validated_(port|mstb)_ref and
friends
-:84: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#84: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:990:
+ rmstb = drm_dp_mst_topology_get_mstb_validated_locked(
-:102: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#102: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1006:
+ rmstb = drm_dp_mst_topology_get_mstb_validated_locked(
-:150: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#150: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1373:
+ mstb_child = drm_dp_mst_topology_get_mstb_validated(
total: 0 errors, 0 warnings, 3 checks, 399 lines checked
5e53f025958a drm/dp_mst: Introduce new refcounting scheme for mstbs and ports
-:22: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("<title line>")' - ie: 'commit 91a25e463130 ("drm/dp/mst:
deallocate payload on port destruction")'
#22:
91a25e463130 ("drm/dp/mst: deallocate payload on port destruction")
-:27: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description
(prefer a maximum 75 chars per line)
#27:
263efde31f97 ("drm/dp/mst: Get validated port ref in
drm_dp_update_payload_part1()")
-:27: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("<title line>")' - ie: 'commit 263efde31f97 ("drm/dp/mst: Get
validated port ref in drm_dp_update_payload_part1()")'
#27:
263efde31f97 ("drm/dp/mst: Get validated port ref in
drm_dp_update_payload_part1()")
-:46: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("<title line>")' - ie: 'commit c54c7374ff44 ("drm/dp_mst: Skip
validating ports during destruction, just ref")'
#46:
c54c7374ff44 ("drm/dp_mst: Skip validating ports during destruction, just ref")
-:51: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+
chars of sha1> ("<title line>")' - ie: 'commit 9765635b3075 ("Revert
"drm/dp_mst: Skip validating ports during destruction, just ref"")'
#51:
9765635b3075 ("Revert "drm/dp_mst: Skip validating ports during destruction,
just ref"")
-:129: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does
MAINTAINERS need updating?
#129:
new file mode 100644
-:511: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#511: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:988:
+ DRM_DEBUG("mstb %p (%d)\n", mstb, kref_read(&mstb->malloc_kref)-1);
^
-:562: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#562: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1039:
+ DRM_DEBUG("port %p (%d)\n", port, kref_read(&port->malloc_kref)-1);
^
-:679: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#679: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1149:
+ DRM_DEBUG("mstb %p (%d)\n", mstb, kref_read(&mstb->topology_kref)-1);
^
-:779: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#779: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1273:
+ DRM_DEBUG("port %p (%d)\n", port, kref_read(&port->topology_kref)-1);
^
-:832: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#832: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1327:
+ mport = drm_dp_mst_topology_get_port_validated_locked(
-:846: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#846: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:1344:
+ rport = drm_dp_mst_topology_get_port_validated_locked(
-:1012: WARNING:BRACES: braces {} are not necessary for any arm of this
statement
#1012: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2058:
+ if (drm_dp_mst_topology_try_get_mstb(rmstb)) {
[...]
+ } else {
[...]
total: 4 errors, 3 warnings, 6 checks, 974 lines checked
a4378c0bb6f7 drm/dp_mst: Restart last_connected_port_and_mstb() if topology ref
fails
3b35c50d8406 drm/dp_mst: Stop releasing VCPI when removing ports from topology
859904901106 drm/dp_mst: Fix payload deallocation on hotplugs using malloc refs
-:97: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#97: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:2274:
+ port = drm_dp_mst_topology_get_port_validated(
total: 0 errors, 0 warnings, 1 checks, 124 lines checked
514f014c71f3 drm/i915: Keep malloc references to MST ports
3c24606c381a drm/amdgpu/display: Keep malloc ref to MST port
6d9550106577 drm/nouveau: Remove bogus cleanup in nv50_mstm_add_connector()
371889f7b60e drm/nouveau: Remove unnecessary VCPI checks in nv50_msto_cleanup()
f0d136a0f492 drm/nouveau: Keep malloc references to MST ports
e4743c105b87 drm/nouveau: Stop unsetting mstc->port, use malloc refs
d242f9257a4b drm/nouveau: Grab payload lock in nv50_msto_payload()
260fc11b1f9a drm/dp_mst: Add some atomic state iterator macros
-:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible
side-effects?
#110: FILE: include/drm/drm_dp_mst_helper.h:710:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state,
__i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr),
&(old_state), &(new_state), (__i)))
-:110: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible
side-effects?
#110: FILE: include/drm/drm_dp_mst_helper.h:710:
+#define for_each_oldnew_mst_mgr_in_state(__state, mgr, old_state, new_state,
__i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr),
&(old_state), &(new_state), (__i)))
-:112: WARNING:LONG_LINE: line over 100 characters
#112: FILE: include/drm/drm_dp_mst_helper.h:712:
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr),
&(old_state), &(new_state), (__i)))
-:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible
side-effects?
#127: FILE: include/drm/drm_dp_mst_helper.h:727:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr),
&(old_state), NULL, (__i)))
-:127: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible
side-effects?
#127: FILE: include/drm/drm_dp_mst_helper.h:727:
+#define for_each_old_mst_mgr_in_state(__state, mgr, old_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr),
&(old_state), NULL, (__i)))
-:129: WARNING:LONG_LINE: line over 100 characters
#129: FILE: include/drm/drm_dp_mst_helper.h:729:
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr),
&(old_state), NULL, (__i)))
-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__state' - possible
side-effects?
#145: FILE: include/drm/drm_dp_mst_helper.h:745:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr),
NULL, &(new_state), (__i)))
-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse '__i' - possible
side-effects?
#145: FILE: include/drm/drm_dp_mst_helper.h:745:
+#define for_each_new_mst_mgr_in_state(__state, mgr, new_state, __i) \
+ for ((__i) = 0; (__i) < (__state)->num_private_objs; (__i)++) \
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr),
NULL, &(new_state), (__i)))
-:147: WARNING:LONG_LINE: line over 100 characters
#147: FILE: include/drm/drm_dp_mst_helper.h:747:
+ for_each_if(__drm_dp_mst_state_iter_get((__state), &(mgr),
NULL, &(new_state), (__i)))
total: 0 errors, 3 warnings, 6 checks, 120 lines checked
945779405902 drm/dp_mst: Start tracking per-port VCPI allocations
-:388: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#388: FILE: drivers/gpu/drm/drm_dp_mst_topology.c:3672:
+
+ }
total: 0 errors, 0 warnings, 1 checks, 464 lines checked
4d20dde05c36 drm/dp_mst: Check payload count in drm_dp_mst_atomic_check()
b6b2a3fc3076 drm/nouveau: Use atomic VCPI helpers for MST
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
